BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
3 stars 1 forks source link

Cross-Browser Cursor Placement Optimization Plugin #174

Closed abelpz closed 3 weeks ago

abelpz commented 2 months ago

This PR introduces a comprehensive overhaul of the CursorHandler plugin. By generating invisible cursor placeholders, the plugin enables users to accurately position their cursor anywhere within a document, regardless of browser compatibility. This resolves longstanding issues such as the inability to place the cursor inside empty elements. Additionally, the plugin ensures efficient resource management by automatically removing unnecessary placeholders when they are no longer required.

codesandbox[bot] commented 2 months ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview
nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c081410b592ee8a93640cb812f5bdd751de2e0c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx run-many -t build`](https://cloud.nx.app/runs/pQz13823d7?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t test`](https://cloud.nx.app/runs/1A6RLdRUUn?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t typecheck`](https://cloud.nx.app/runs/u5GQDX2J8l?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t lint`](https://cloud.nx.app/runs/XmYV1pfSl5?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

abelpz commented 3 weeks ago

Wow, there is a lot of clever work here.

I noticed while manually testing with the left and right arrow keys that there are more spaces than I expect. Also when clicking around, there are places I can't click on but can get to with arrow keys. We could talk about this when we meet next week.

Having said that, this is still a huge improvement than without it so you could still choose to merge it and fix up corner cases later.

Thanks, I made the requested changes and will proceed to merge then.