BiblioNexus-Foundation / scripture-editors

Monorepo for various Scripture editors
MIT License
3 stars 1 forks source link

Add a separate plugin with a filter input for the nodes selection menu #190

Closed abelpz closed 2 weeks ago

abelpz commented 1 month ago

This PR incorporates code from the Typeahead node selection menu plugin into a new Node selection menu plugin. The new menu activates when the user presses the trigger key, ensuring that no text is entered into the editor during its active state.

The menu includes an input field that displays user input and dynamically updates the eligible node markers list as the query changes, mimicking Paratext's behavior. The user can navigate through the nodes list using the up and down arrow keys, and can select a node by clicking on it or pressing the enter or tab keys as the desired node is highlighted.

The menu can be hidden by pressing the escape key, backspace when the input is empty, or moving the cursor to a different position in the editor.

codesandbox[bot] commented 1 month ago

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview
nx-cloud[bot] commented 4 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe16122736c455ac6efc2c8851a91e72e4036b64. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx run-many -t build`](https://cloud.nx.app/runs/3pK8GGPOl6?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t test`](https://cloud.nx.app/runs/vuvyPfS2w8?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t typecheck`](https://cloud.nx.app/runs/Ry86WwRZ0N?utm_source=pull-request&utm_medium=comment) - [`nx run-many -t lint`](https://cloud.nx.app/runs/TJ6TGsS6OV?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

irahopkinson commented 3 weeks ago

There was another issue but I can't find consistently reproduceable steps. Something like select text and try \pm + enter, then \f + enter, then create a new paragraph and try \pm + enter, some times the new pm paragraph would contain an empty note.

abelpz commented 2 weeks ago

There was another issue but I can't find consistently reproduceable steps. Something like select text and try \pm + enter, then \f + enter, then create a new paragraph and try \pm + enter, some times the new pm paragraph would contain an empty note.

@irahopkinson this should be fixed after the latest commit