BibliothecaDAO / RealmsWorld

The Hub, Marketplace and Centrepiece of the Realms World.
https://realms.world/
MIT License
20 stars 39 forks source link

feat: Upgrade TX notifications #241

Open RedBeardEth opened 4 months ago

RedBeardEth commented 4 months ago

Describe the feature you'd like to request

image

Notifications in the sidebar are currently generated from: 1) a zustand local storage store with addTx method called on client tx submissions (e.g claiming Lords) 2) fetching various data sources (for the Realms nft bridge) in the useTransactions hook and merging with the zustand store above

Describe the solution you'd like to see

The transaction notifications in the account sidebar should:

Additional information

The (currently messy) logic for data fetching will soon be improved (awaiting apibara dna v2 to unify Starknet and L1 data) and more data sources will be added (e.g sales on the nft marketplace) - so the useTransactions hook should be generalised (not too specified to bridge transaction data)

Dprof-in-tech commented 4 months ago

Hello @RedBeardEth , I'm Isaac a fullstack developer with contributions to multiple projects on onlydust. I Would love to be assigned to this issue.

Ugo-X commented 4 months ago

Hello Project Lead! @RedBeardEth I'm Ugo, a fullstack(js,React,Node,Next.js,Three.js) developer with a strong track record in OD hack projects. I've been actively involved since Edition 1, contributing to various initiatives. Having used OnlyDust extensively, I'm confident in my ability to tackle new challenges. I'm eager to leverage my skills and experience to contribute effectively. Below is the link to my only dust profile: https://app.onlydust.com/u/Ugo-X

4eyes52 commented 2 months ago

idea for refactor of useTransactions hook @RedBeardEth :

First Part of Refactor:

So the sheet would basically organize the transactions into separate transaction types instead of combining them into one list.

This would provide an initial first step at generalizing the transactions in the wallet sheet and making it easier to differentiate between the types of transactions the sheet currently displays.

Can implement in the working pull request which cleans up storing transactions returned from useTransactions in localstorage: https://github.com/BibliothecaDAO/RealmsWorld/pull/288

I will update this discussion with second part of refactor idea if this first refactor idea is acceptable @RedBeardEth. Let me know your thoughts!