search

BibliothecaDAO / eternum

onchain eternal game
https://alpha-eternum.realms.world
MIT License
46 stars 34 forks source link

bumps burner to stop deletion #1018

Closed ponderingdemocritus closed 3 months ago

ponderingdemocritus commented 3 months ago

PR Type

dependencies

Description

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Bump `@dojoengine/create-burner` dependency version           
client/package.json
  • Updated @dojoengine/create-burner dependency version from
    ^0.7.0-alpha.2 to ^0.7.5.
    		•  +1/-1     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    vercel[bot] commented 3 months ago

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 1:35am
    github-actions[bot] commented 3 months ago

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None
    github-actions[bot] commented 3 months ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Align versioning of ESLint plugins and configurations to ensure consistency and avoid conflicts ___ **Ensure that the versioning for @typescript-eslint/eslint-plugin and its related parser and
    eslint configurations are aligned to prevent version conflicts and ensure linting
    consistency.** [pnpm-lock.yaml [194]](https://github.com/BibliothecaDAO/eternum/pull/1018/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR194-R194) ```diff -version: 7.13.0(@typescript-eslint/parser@7.13.0(eslint@8.57.0)(typescript@5.4.4))(eslint@8.57.0)(typescript@5.4.4) +version: 7.13.0(@typescript-eslint/parser@7.13.0)(eslint@8.57.0)(typescript@5.4.4) ```
    Suggestion importance[1-10]: 9 Why: Ensuring that versioning for ESLint plugins and configurations are aligned is crucial for preventing conflicts and maintaining linting consistency. This suggestion addresses a best practice in dependency management.
    		9
    Enhancement
    Update all related dependencies to match the new version for compatibility ___ **Update all related dependencies when upgrading to a new version to maintain compatibility
    and avoid potential issues with mismatched dependencies.** [pnpm-lock.yaml [22]](https://github.com/BibliothecaDAO/eternum/pull/1018/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR22-R22) ```diff -version: 0.7.0-alpha.2(starknet@6.7.0(encoding@0.1.13))(typescript@5.4.4) +version: 0.7.5(starknet@6.7.0(encoding@0.1.13))(typescript@5.4.4) ```
    Suggestion importance[1-10]: 8 Why: This suggestion is important for maintaining compatibility across dependencies when upgrading to a new version. It ensures that all related packages are updated accordingly.
    		8
    Possible issue
    Ensure version consistency across related packages to prevent compatibility issues ___ **Consider using consistent versioning for dependencies to avoid potential conflicts and
    ensure compatibility. The version 0.7.5 for @dojoengine/create-burner might introduce
    breaking changes if other related packages are not updated accordingly.** [pnpm-lock.yaml [25]](https://github.com/BibliothecaDAO/eternum/pull/1018/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR25-R25) ```diff -version: 0.7.5(react-dom@18.2.0(react@18.2.0))(react@18.2.0)(starknet@6.7.0(encoding@0.1.13))(typescript@5.4.4) +version: 0.7.0-alpha.2(react-dom@18.2.0(react@18.2.0))(react@18.2.0)(starknet@6.7.0(encoding@0.1.13))(typescript@5.4.4) ```
    Suggestion importance[1-10]: 7 Why: The suggestion to use consistent versioning is valid and can help prevent potential compatibility issues. However, it assumes that the newer version might introduce breaking changes without specific evidence.
    		7
    Maintainability
    Review and potentially remove unnecessary dependencies to simplify project management ___ **Avoid adding unnecessary dependencies to maintain a clean and manageable project
    structure. Review if encoding@0.1.13 is essential for the @web3mq/client package.** [pnpm-lock.yaml [82]](https://github.com/BibliothecaDAO/eternum/pull/1018/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bbR82-R82) ```diff -version: 1.0.25(encoding@0.1.13) +version: 1.0.25 ```
    Suggestion importance[1-10]: 6 Why: While removing unnecessary dependencies can improve maintainability, the suggestion does not provide enough context to determine if `encoding@0.1.13` is indeed unnecessary for `@web3mq/client`.
    		6