bump to v1 - Githubissues

ponderingdemocritus commented 1 week ago

Summary by CodeRabbit

Release Notes

New Features
- Updated dependency from bushido_trophy to arcade_trophy, enhancing trophy management and event handling.
- Introduced a new module for map generation, facilitating the creation of map features and resource extraction.
Bug Fixes
- Resolved inconsistencies in event names related to trophy creation and progression.
Documentation
- Updated references and documentation to reflect the new arcade_trophy module.
Chores
- Streamlined configuration files and dependencies for improved stability and performance.
- Updated deployment scripts and tool versions to transition from release candidate to stable versions.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 12, 2024 9:46am

1 Skipped Deployment

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request involve updates to multiple configuration files and source code modules, primarily focusing on replacing the bushido_trophy dependency with arcade_trophy across various components. This includes updating dependency versions in Scarb.toml, modifying environment variables in dojo_prod.toml, and renaming event types in JSON manifest files. Additionally, import statements in several Cairo source files have been adjusted to reflect the new dependency, ensuring that the overall structure and functionality remain intact while transitioning to the new trophy management system.

Changes

File Path	Change Summary
`contracts/Scarb.toml`	Updated `dojo`, `dojo_cairo_test` to stable version `v1.0.0`; replaced `bushido_trophy` with `arcade_trophy`.
`contracts/dojo_prod.toml`	Updated `account_address`, `private_key`, and `rpc_url` in `[env]` section.
`contracts/manifest_dev.json`	Renamed event types from `bushido_trophy` to `arcade_trophy`.
`contracts/manifest_prod.json`	Renamed event types from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems/combat/contracts/battle_systems.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems/combat/contracts/battle_pillage_systems.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems/config/contracts.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`; added `start` and `end` parameters to `dojo_init`.
`contracts/src/systems/hyperstructure/contracts.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`; enhanced functions for hyperstructure management.
`contracts/src/systems/map/contracts.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems/realm/contracts.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems/transport/contracts/donkey_systems.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/utils/tasks/index.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/utils/testing/world.cairo`	Updated event references from `bushido_trophy` to `arcade_trophy`.
`contracts/src/utils/trophies/index.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/utils/trophies/interface.cairo`	Updated import from `bushido_trophy` to `arcade_trophy`.
`contracts/src/systems.cairo`	Added new module `map_generation` under the `map` namespace.
`contracts/src/systems/dev/contracts/bank.cairo`	Updated import to `InternalMapGenerationSystemsImpl`, maintaining existing logic.
`contracts/src/systems/map/map_generation.cairo`	Introduced new contract module with methods for map feature generation and event handling.
`contracts/src/systems/map/tests.cairo`	Updated test cases to utilize `InternalMapGenerationSystemsImpl` instead of `InternalMapSystemsImpl`.
`.github/workflows/test-contracts.yml`	Added `paths-ignore` for pull requests; updated Dojo artifact download URL.
`.tool-versions`	Updated `dojo` version from `1.0.0-rc.1` to `1.0.0`.
`contracts/.tool-versions`	Updated `dojo` version from `1.0.0-rc.1` to `1.0.0`.
`scripts/deploy.sh`	Updated deployment commands to remove `-rc.1` from version strings for `katana` and `torii` slots.

Possibly related PRs

#1848: The changes in this PR involve updates to the dojo dependency, which is also referenced in the main PR's updates to Scarb.toml. Both PRs focus on dependency management, specifically transitioning from release candidates to stable versions.
#1932: This PR introduces a new component that retrieves stamina costs from the configManager, which aligns with the main PR's focus on updating dependencies and configurations related to the arcade_trophy and dojo components.
#2015: The modifications in this PR include changes to the messaging system in the Discord bot, which may relate to the event handling updates in the main PR, particularly the changes involving arcade_trophy events.

Poem

In the meadow where trophies gleam,
A new name shines, a fresh new dream.
Arcade's the tune, the trophies now play,
As we hop along, in a joyful ballet.
With every leap, our spirits soar,
Celebrating changes, forevermore! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Failed to generate code suggestions for PR

BibliothecaDAO / eternum

bump to v1 #2091