search

BibliothecaDAO / eternum

onchain eternal game
https://eternum.realms.world
MIT License
49 stars 38 forks source link

balancing #2110

Closed ponderingdemocritus closed 1 week ago

ponderingdemocritus commented 1 week ago

Summary by CodeRabbit

Release Notes

These updates aim to enhance user experience through improved aesthetics and balanced gameplay mechanics.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:56pm
eternum-docs ❌ Failed (Inspect) Nov 15, 2024 7:56pm
eternum-landing ❌ Failed (Inspect) Nov 15, 2024 7:56pm
mentatbot[bot] commented 1 week ago

You are out of MentatBot reviews. Your usage will refresh November 18 at 08:00 AM.

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces modifications across several components and constants in the codebase. Notably, the BaseContainer component gains a new optional property scrollbarSide, allowing for customizable scrollbar positioning. The styling of the BaseContainer is enhanced in both the left and right navigation modules, adding rounded corners and borders. Additionally, various constants related to resource production and troop food consumption are adjusted, affecting gameplay dynamics and resource allocation.

Changes

File Path Change Summary
client/src/ui/containers/BaseContainer.tsx Added optional property scrollbarSide to BaseContainerProps. Modified className in BaseContainer.
client/src/ui/modules/navigation/LeftNavigationModule.tsx Updated BaseContainer styling to include rounded corners and borders. No changes to logic.
client/src/ui/modules/navigation/RightNavigationModule.tsx Enhanced BaseContainer styling with rounded corners and borders. No changes to logic.
sdk/packages/eternum/src/constants/global.ts Updated several constants: HYPERSTRUCTURE_POINTS_PER_CYCLE, HYPERSTRUCTURE_POINTS_ON_COMPLETION, STARTING_RESOURCES_INPUT_PRODUCTION_FACTOR, and mercenary upper bounds.
sdk/packages/eternum/src/constants/quests.ts Modified resource amounts for various quest types, including increases and new assignments.
sdk/packages/eternum/src/constants/resources.ts Adjusted output values for resources and significantly reduced input amount for Donkey.
sdk/packages/eternum/src/constants/troops.ts Increased food consumption values for Paladin, Knight, and Crossbowman.
client/src/hooks/context/policies.tsx Removed double quotes around keys in policies array, preserving structure and content.
client/src/three/sound/utils.ts Simplified assignment in playBuildingSound function without altering logic.
client/src/ui/components/bank/LiquidityTable.tsx Reformatted filtering logic for filteredResources for improved readability.
landing/schema.graphql Updated ModelUnion definition by removing leading pipe from eternum_AcceptOrder.

Possibly related PRs

Suggested reviewers

🐇 In the code, we hop and play,
With scrollbars now in a new way.
Borders round, a golden gleam,
In the UI, we build our dream!
Resources shift, and troops consume,
In this world, we all shall bloom! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 week ago

Failed to generate code suggestions for PR