Fix decimal places in AMM against Lords amount

aymericdelab commented 1 week ago

This pull request fixes the issue #2026 by updating the decimal places in the AMM against Lords amount. The changes include:

In the LiquidityResourceRow.tsx file, the lordsDifferencePercentage and resourceDifferencePercentage are now formatted with 4 decimal places instead of 2.
In the LiquidityTable.tsx file, the searchTerm.toLowerCase() is now formatted with 4 decimal places instead of 2.
In the Swap.tsx file, the lpFee and ownerFee are now formatted with 4 decimal places instead of 2.

These changes ensure that the decimal places in the AMM against Lords amount are more accurate and precise.

Summary by CodeRabbit

Release Notes

New Features
- Introduced a new InputResourcesPrice component for calculating and displaying production costs based on input resources.
Improvements
- Enhanced the precision of percentage displays in the MyLiquidity component to four decimal places.
- Updated slippage and fee displays in the ResourceSwap component for improved accuracy and consistency.
Bug Fixes
- Clarified warning messages in the ResourceSwap component to better indicate swap restrictions.
Style
- Improved code readability in the LiquidityTable component without affecting functionality.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 3:15pm
eternum-docs	❌ Failed (Inspect)			Nov 15, 2024 3:15pm

1 Skipped Deployment

mentatbot[bot] commented 1 week ago

You are out of MentatBot reviews. Your usage will refresh November 18 at 08:00 AM.

coderabbitai[bot] commented 1 week ago

Walkthrough

This pull request includes modifications across several components in the codebase. The MarketManager class now actively imports configManager and SetupResult, ensuring necessary dependencies are available. The LiquidityResourceRow component has improved the precision of percentage displays and introduced a new InputResourcesPrice component for calculating production costs. The LiquidityTable component's filtering method has been reformatted for better readability without functional changes. Lastly, the Swap component enhances fee handling and slippage calculations, standardizing displayed values to four decimal places while maintaining existing logic.

Changes

File Path	Change Summary
client/src/dojo/modelManager/MarketManager.ts	Added active import statements for `configManager` and `SetupResult`.
client/src/ui/components/bank/LiquidityResourceRow.tsx	Updated percentage formatting to four decimal places and added a new `InputResourcesPrice` component.
client/src/ui/components/bank/LiquidityTable.tsx	Reformatted the `filter` method for readability; no functional changes made.
client/src/ui/components/bank/Swap.tsx	Enhanced fee handling and slippage calculations with four decimal place formatting; clarified warning messages.

Possibly related PRs

#2053: The changes in the LiquidityResourceRow component regarding the formatting of numerical outputs are related to the main PR's modifications in the MarketManager class, as both involve adjustments to how values are displayed and formatted in the UI, particularly concerning market prices and liquidity amounts.

Suggested reviewers

bob0005
edisontim

🐇 "In the code where numbers dance,
Precision now gets a second chance.
Imports tidy, components new,
Formatting shines, all in view.
With every line, our work's a treat,
Hopping forward, can't be beat!" 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Failed to generate code suggestions for PR

BibliothecaDAO / eternum