search

BibliothecaDAO / eternum

onchain eternal game
https://eternum.realms.world
MIT License
49 stars 37 forks source link

Mithril listed incorrectly in squence in market (third rarest resource) #2112

Closed aymericdelab closed 1 week ago

aymericdelab commented 1 week ago

Fixes #2064

Summary by CodeRabbit

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:43pm
eternum-docs ❌ Failed (Inspect) Nov 15, 2024 3:43pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **eternum-landing** | ⬜️ Ignored ([Inspect](https://vercel.com/loot-bibliotheca/eternum-landing/BJ6g2nTjy4Snb8fRf82CCcCsHy2R)) | [Visit Preview](https://eternum-landing-git-raschel-issue2064-loot-bibliotheca.vercel.app) | | Nov 15, 2024 3:43pm |
mentatbot[bot] commented 1 week ago

You are out of MentatBot reviews. Your usage will refresh November 18 at 08:00 AM.

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces modifications across three components: LiquidityTable, MarketOrderPanel, and MarketResourceSidebar. The changes primarily focus on improving code clarity and robustness in handling resource identifiers. The LiquidityTable component's filtering logic is reformatted for better readability. The MarketOrderPanel and MarketResourceSidebar components update their handling of resource identifiers, replacing resource with resourceId and enhancing error handling. Overall, the changes aim to streamline resource management without altering existing functionalities.

Changes

File Path Change Summary
client/src/ui/components/bank/LiquidityTable.tsx Reformatting of filteredResources computation for improved readability; unchanged filtering logic.
client/src/ui/components/trading/MarketOrderPanel.tsx Updated props from resource to resourceId, adjusted resource access logic, and enhanced error handling.
client/src/ui/components/trading/MarketResourceSideBar.tsx Changed filtering logic to use RESOURCE_TIERS and updated props to utilize resourceId.

Assessment against linked issues

Objective Addressed Explanation
Mithril listed incorrectly in sequence in market (#2064) ❓ It is unclear if the changes directly address the listing issue.

Possibly related PRs

Suggested reviewers

Poem

In the land of trades and resources bright,
A table of liquidity shines with delight.
With IDs now clear and logic refined,
The market's secrets are easier to find.
So hop along, dear friends, take a look,
For clarity blooms in every nook! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.