add lost troops in pillage

aymericdelab commented 1 week ago

Summary by CodeRabbit

Release Notes

New Features
- Enhanced battle data structures to include detailed tracking of troop losses and ownership changes during battles.
- Updated user interface for pillage history, improving clarity and visual organization, including new sections for lost troops.
- Introduced the TroopDisplay component for improved troop information presentation across various UI components.
Bug Fixes
- Improved error handling and validations for battle initiation and actions to prevent incorrect states.
Documentation
- Updated metadata types and documentation to reflect new fields and changes in battle-related components.
Chores
- Added new contract entries and updated existing contract addresses and class hashes to ensure compatibility with the latest deployments.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 4:36pm
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 19, 2024 4:36pm

1 Skipped Deployment

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces significant changes to several components related to battle events in the codebase. Key modifications include updates to the BattleClaimData and BattlePillageData structures, enhancing how battle-related data is captured, including new fields for troop losses and ownership details. Additionally, the user interface for displaying pillage history has been improved, and configuration files have been updated to reflect new contract entries and address changes. Overall, these alterations aim to provide more detailed tracking of battle events and enhance user experience.

Changes

File Path	Change Summary
client/src/dojo/contractComponents.ts	- Updated `BattleClaimData`: replaced `previous_owner` with `claimee_address` and `claimee_name`. - Expanded `BattlePillageData`: added `attacker_lost_troops`, `structure_lost_troops`, and `pillaged_structure_owner_name`. - Updated metadata types.
client/src/ui/components/military/PillageHistory.tsx	- Enhanced `PillageHistoryItem` layout and structure. - Updated success/failure messages to "Successful Raid" or "Failed Raid". - Restructured resource display and added troop loss sections using `TroopDisplay`.
client/src/ui/components/military/TroopChip.tsx	- Modified `TroopMenuRow` to `TroopDisplay`, adding optional props: `direction`, `iconSize`, and `negative`, enhancing layout flexibility and conditional styling for troop counts.
contracts/dojo_dev.toml	- Added entries: `"eternum-map_generation_systems"` (duplicate) and `"eternum-battle_utils_systems"` in the `writers` section.
contracts/manifest_dev.json	- Added new contract: `battle_utils_systems` with address and class hash. - Enhanced ABI structure with new interfaces and functions for troop management. - Expanded event definitions for battle utilities.
contracts/src/models/event.cairo	- Updated `BattleClaimData`: replaced `previous_owner` with `claimee_address` and added `claimee_name`. - Expanded `BattlePillageData` with new fields for troop losses and ownership details. - Updated imports.
contracts/src/systems/combat/contracts/battle_systems.cairo	- Enhanced battle initiation and claiming logic. - Updated `battle_pillage` function to calculate troop losses and improved event emissions. - Added error handling for battle state validations.
client/src/ui/components/battles/BattleListItem.tsx	- Replaced `TroopMenuRow` with `TroopDisplay` for rendering troop information.
client/src/ui/components/military/ArmyChip.tsx	- Replaced `TroopMenuRow` with `TroopDisplay` for displaying troop information.
client/src/ui/components/trading/MarketModal.tsx	- Replaced `TroopMenuRow` with `TroopDisplay` for troop information display.
client/src/ui/components/worldmap/structures/StructureListItem.tsx	- Replaced `TroopMenuRow` with `TroopDisplay` for troop information display.

Possibly related PRs

#1843: Modifies the contractComponents.ts file, which is directly related to the changes made in the main PR regarding the BattleClaimData and BattlePillageData structures, as both involve updates to the same components.
#1847: This PR introduces changes to the BattleManager class, which includes updates to the logic for claiming structures and managing battles, aligning with the modifications made in the main PR regarding battle-related data structures.
#1848: This PR enhances the ClientConfigManager, which may indirectly relate to the main PR's changes in battle data structures by improving overall configuration management, impacting how battle data is handled.
#1861: This PR modifies the BattleManager class, which is relevant to the main PR's focus on battle data structures, particularly in how battles and troop management are handled.
#2002: This PR addresses ownership checking, which is relevant to the main PR's changes in battle-related data structures, as ownership is a critical aspect of battle mechanics.
#2102: This PR introduces a user battles tab, which is directly related to the main PR's focus on battle data structures and enhances the user interface for managing battles.
#2104: This PR modifies the SettlementConfig structure, which may relate to the main PR's changes in battle data structures by impacting how settlements and battles interact within the game.

Suggested reviewers

ponderingdemocritus
bob0005

Poem

🐇 In the land of battle, where heroes tread,
New tales of glory, where brave hearts led.
Troops lost and claimed, in the heat of the fight,
With clearer paths drawn, our future is bright!
So gather your courage, let victories ring,
For in this grand tale, together we sing! 🎶

[!WARNING]

Rate limit exceeded

@aymericdelab has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.

📥 Commits
Reviewing files that changed from the base of the PR and between 97d4fc67d6a28c7001f41cafd45227c1c5061ee2 and 9c51dc63773cad190758b8d58d7d6877b918ee03.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Failed to generate code suggestions for PR

BibliothecaDAO / eternum