search

BibliothecaDAO / eternum

onchain eternal game
https://eternum.realms.world
MIT License
49 stars 38 forks source link

Main #2124

Closed aymericdelab closed 1 week ago

aymericdelab commented 1 week ago

Summary by CodeRabbit

Release Notes

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:39pm
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:39pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **eternum-landing** | ⬜️ Ignored ([Inspect](https://vercel.com/loot-bibliotheca/eternum-landing/7JFrEvT4deoYDRvQGEjECLr4osCY)) | | | Nov 19, 2024 4:39pm |
coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request introduce a new event component named GameEnded to the contractComponents.ts file, enhancing event tracking capabilities. The LeaderboardManager class is modified to include a new property for tracking game end timestamps and updates to its methods for improved data handling. The setup.ts file alters timeout values for synchronization functions. Additionally, the useLeaderBoardStore.tsx file is updated to handle the new GameEnded event within the leaderboard context. Finally, the resource_systems.cairo file enforces a season check before resource operations.

Changes

File Path Change Summary
client/src/dojo/contractComponents.ts Added a new event component GameEnded in eventsComponents function with properties winner_address (BigInt) and timestamp (Number).
client/src/dojo/modelManager/LeaderboardManager.ts Updated pointsOnCompletionPerPlayer to Map<ContractAddress, Map<ID, number>>, removed configManager, added gameEndedTimestamp: number | undefined, and added method processGameEndedEvent. Adjusted setPointsGeneratedByShares to check gameEndedTimestamp and updated logic for event processing.
client/src/dojo/setup.ts Increased timeout for getSyncEntities and getSyncEvents from 10_000 ms to 20_000 ms.
client/src/hooks/store/useLeaderBoardStore.tsx Added import for useEntityQuery and expanded event handling in useSubscriptionToHyperstructureEvents to include GameEnded. Updated defineQuery for HyperstructureCoOwnersChange to include runOnInit. Added new effect to process GameEnded events using LeaderboardManager.
contracts/src/systems/resources/contracts/resource_systems.cairo Introduced a dependency on SeasonImpl and added checks in approve, send, and pickup methods to ensure the current season is active before executing resource operations.

Possibly related PRs

🐇 In the land of code, a game has ceased,
A GameEnded event, our joy increased.
With timestamps and winners, we track with glee,
In the leaderboard's heart, new tales we see.
So hop along, dear friends, let’s celebrate,
For every game’s end, a new start awaits! 🎉

[!WARNING]

Rate limit exceeded

@aymericdelab has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between c55e346d7fa35309ee037e1bfadae13cc3213432 and 92c25ba563e9b66f9a35197b46c226c828aae5a9.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.