Closed aymericdelab closed 5 days ago
vercel[bot]
commented
6 days ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| eternum | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 21, 2024 10:28am |
| eternum-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 21, 2024 10:28am |
coderabbitai[bot]
commented
6 days ago The pull request introduces a pillage simulation feature to the application, enhancing the existing military simulation capabilities. It includes the addition of new components such as PillageSimulationPanel and Troops, updates to the EntitiesArmyTable, and modifications to existing components to integrate pillage functionality. The changes also involve adjustments to type definitions and utility functions to accommodate the new simulation logic while maintaining existing functionalities.
| File Path | Change Summary |
|---|---|
client/src/ui/components/military/EntitiesArmyTable.tsx |
Updated import paths for BattleSimulation and added PillageSimulation. Added a button to trigger pillage simulation. |
client/src/ui/components/navigation/Config.tsx |
Added PillageSimulation to OSWindows type and declared new constant pillageSimulation. |
client/src/ui/components/worldmap/battles/BattleSimulationPanel.tsx |
Restructured layout to grid, updated rendering logic, and simplified battle object construction. |
client/src/ui/components/worldmap/battles/PillageSimulationPanel.tsx |
Introduced a new component for simulating pillage scenarios with state management and UI layout. |
client/src/ui/components/worldmap/battles/Troops.tsx |
Added a new component to display and manage troop resources in a grid layout. |
client/src/ui/modules/military/battle-view/BattleActions.tsx |
Enhanced tooltip content and updated mouseEnterRaid function for better readability. |
client/src/ui/modules/military/battle-view/utils.tsx |
Introduced ArmyBattleInfo type and updated function signatures to use this new type. |
client/src/ui/modules/simulation/pillage-simulation.tsx |
Added a new component for managing the pillage simulation popup and interface. |
sdk/packages/eternum/src/utils/battleSimulation.ts |
Added troops() method to TroopsSimulator class and modified fullHealth method to return detailed health info. |
.tool-versions |
Updated dojo dependency version from 1.0.0 to 1.0.1. |
contracts/.tool-versions |
Updated dojo dependency version from 1.0.0 to 1.0.1. |
scripts/deploy.sh |
Incremented deployment version from v1.0.0 to v1.0.1 for two instances in the deployment script. |
| Objective | Addressed | Explanation |
|---|---|---|
| Add pillage simulation tool (#[2123]) | ✅ |
TroopConfig component in client/src/dojo/contractComponents.ts align with the main PR's updates to troop management and simulation features.BattleManager class regarding troop presence and claimability are relevant as they may interact with the new pillage simulation features introduced in the main PR.toInteger may support the new features in the main PR by optimizing performance and reducing bundle size, indirectly benefiting the new simulation functionalities.In fields of battle, brave and bold,
A pillage tale now unfolds.
With troops in line, we strategize,
For glory awaits beneath the skies.
So gather round, let battles begin,
For every raid, there's joy to win! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
github-actions[bot]
commented
6 days ago Failed to generate code suggestions for PR
This pull request adds a new feature to the client that allows users to simulate pillage scenarios. It includes the following changes:
Added a new file
pillage-simulation.tsxin theclient/src/ui/modules/simulationdirectory that contains the implementation of the pillage simulation tool.Modified the
Config.tsxfile in theclient/src/ui/components/navigationdirectory to include a new constantpillageSimulationthat represents the pillage simulation tool in the navigation menu.Modified the
EntitiesArmyTable.tsxfile in theclient/src/ui/components/militarydirectory to add a new button that triggers the pillage simulation tool.Added a new file
Troops.tsxin theclient/src/ui/components/worldmap/battlesdirectory that contains the component for displaying troops in the pillage simulation tool.Modified the
BattleActions.tsxfile in theclient/src/ui/modules/military/battle-viewdirectory to display the outcome of the pillage simulation, including troops loss, success chance, and max resources stolen.Fixes #2123
Summary by CodeRabbit
Release Notes
New Features
PillageSimulationfeature, allowing users to simulate pillage scenarios alongside existing battle simulations.PillageSimulationPanelto display results and outcomes of the pillage simulation.BattleSimulationPanelwith improved layout and clearer display of battle results.EntitiesArmyTable.User Interface Improvements
Troopscomponent to manage and display troop resources in a grid layout.Bug Fixes
ArmySelectorcomponent with the updated user interface.These changes collectively improve the simulation experience and provide users with clearer and more engaging interfaces.