search

BibliothecaDAO / eternum

onchain eternal game
https://eternum.realms.world
MIT License
49 stars 38 forks source link

[client] interactive hexes bug #2134

Closed r0man1337 closed 5 days ago

r0man1337 commented 5 days ago
  1. Fixed a bug where interactive hexes disappear when moving through the world map.
  2. Fixed a bug with the hexagon grid below highlighted hexes flickering.

Summary by CodeRabbit

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:34pm
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 3:34pm
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **eternum-landing** | ⬜️ Ignored ([Inspect](https://vercel.com/loot-bibliotheca/eternum-landing/8e26UMW3mKnWmMFpjamz2dqHwpHb)) | [Visit Preview](https://eternum-landing-git-fix-hexes-loot-bibliotheca.vercel.app) | | Nov 21, 2024 3:34pm |
mentatbot[bot] commented 5 days ago

You are out of MentatBot reviews. Your usage will refresh November 25 at 08:00 AM.

coderabbitai[bot] commented 5 days ago

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on adjustments to rendering orders within a Three.js scene. The constant AURA_RENDER_ORDER is updated, affecting the rendering priority of the Aura mesh. The HighlightHexManager class sees a similar adjustment to its highlightMesh. Additionally, a new method, computeInteractiveHexes, is added to the WorldmapScene class to enhance the processing of hexagonal grid interactions and rendering efficiency.

Changes

File Change Summary
client/src/three/components/Aura.ts Constant AURA_RENDER_ORDER updated from 1 to 3, affecting the auraMesh rendering order.
client/src/three/components/HighlightHexManager.ts highlightMesh render order updated from 2 to 5; import statements rearranged.
client/src/three/components/InstancedBiome.tsx Added conditional block in constructor to set renderOrder to 1 for instances named "Outline".
client/src/three/scenes/Worldmap.ts Added method computeInteractiveHexes for batch processing of hex interactions; modified updateHexagonGrid to call this new method.

Possibly related PRs

Suggested reviewers

Poem

🐇 In the world of Three.js, we hop and play,
With render orders shifting, brightening the day.
From Aura to Hexes, our meshes align,
In a dance of visuals, oh how they shine!
So here’s to the changes, let’s cheer and rejoice,
For a canvas of wonder, we all have a voice! 🎨✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 5 days ago

Failed to generate code suggestions for PR