Closed ponderingdemocritus closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
eternum | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Jun 21, 2024 1:16am |
โฑ๏ธ Estimated effort to review [1-5] | 4 |
๐งช Relevant tests | No |
๐ Security concerns | No |
โก Key issues to review |
Possible Bug: Renaming of ShardsMine to FragmentMine across multiple files may require careful validation to ensure all references are correctly updated and no functionality is broken. |
Code Consistency: The PR includes a lot of UI changes and enhancements. It's important to ensure that these changes are consistent across different modules and components. | |
Performance Concerns: The changes in the market order panel and other UI components could potentially impact performance due to increased complexity in the DOM and CSS. This should be reviewed and tested. |
Failed to generate code suggestions for PR
PR Type
enhancement, bug fix
Description
ShardsMine
toFragmentMine
across multiple files.Changes walkthrough ๐
22 files
BottomNavigation.tsx
Cleaned up imports and updated navigation configuration.
client/src/ui/modules/navigation/BottomNavigation.tsx - Removed unused imports. - Updated navigation configuration.
MarketOrderPanel.tsx
Improved UI styling for market order panel.
client/src/ui/components/trading/MarketOrderPanel.tsx
MarketModal.tsx
Enhanced market modal layout and added headers.
client/src/ui/components/trading/MarketModal.tsx
buildings.ts
Renamed ShardsMine to FragmentMine in building constants.
sdk/packages/eternum/src/constants/buildings.ts - Renamed `ShardsMine` to `FragmentMine`.
HintModal.tsx
Added new hint sections to HintModal.
client/src/ui/components/hints/HintModal.tsx - Added new hint sections for various game aspects.
HintBox.tsx
Display quest rewards and adjusted styles.
client/src/ui/components/hints/HintBox.tsx
ExistingBuildings.tsx
Renamed ShardsMine to FragmentMine in existing buildings.
client/src/ui/components/construction/ExistingBuildings.tsx - Renamed `ShardsMine` to `FragmentMine`.
ArmyChip.tsx
Reorganized and improved army information display.
client/src/ui/components/military/ArmyChip.tsx
structures.ts
Renamed ShardsMine to FragmentMine in structure constants.
sdk/packages/eternum/src/constants/structures.ts - Renamed `ShardsMine` to `FragmentMine`.
ArmyInfoLabel.tsx
Enhanced army info label with Headline component.
client/src/ui/components/worldmap/armies/ArmyInfoLabel.tsx - Added `Headline` component for better text styling.
SelectPreviewBuilding.tsx
Renamed ShardsMine to FragmentMine in building selection.
client/src/ui/components/construction/SelectPreviewBuilding.tsx - Renamed `ShardsMine` to `FragmentMine`.
Combat.tsx
Added combat hint section.
client/src/ui/components/hints/Combat.tsx - Added new hint section for combat.
Steps.tsx
Updated onboarding step title.
client/src/ui/modules/onboarding/Steps.tsx - Updated onboarding step title.
ShardsMines.tsx
Renamed ShardsMine to FragmentMine in world map buildings.
client/src/ui/components/models/buildings/worldmap/ShardsMines.tsx - Renamed `ShardsMine` to `FragmentMine`.
ArmyList.tsx
Updated army creation instructions.
client/src/ui/components/military/ArmyList.tsx - Updated army creation instructions.
Guilds.tsx
Added guilds hint section.
client/src/ui/components/hints/Guilds.tsx - Added new hint section for guilds.
TheMap.tsx
Added map hint section.
client/src/ui/components/hints/TheMap.tsx - Added new hint section for the map.
Hyperstructures.tsx
Added hyperstructures hint section.
client/src/ui/components/hints/Hyperstructures.tsx - Added new hint section for hyperstructures.
Points.tsx
Added points hint section.
client/src/ui/components/hints/Points.tsx - Added new hint section for points.
Trading.tsx
Added trading hint section.
client/src/ui/components/hints/Trading.tsx - Added new hint section for trading.
structure.cairo
Renamed ShardsMine to FragmentMine in structure model.
contracts/src/models/structure.cairo - Renamed `ShardsMine` to `FragmentMine`.
contracts.cairo
Renamed ShardsMine to FragmentMine in map system.
contracts/src/systems/map/contracts.cairo - Renamed `ShardsMine` to `FragmentMine`.
1 files
resources.ts
Fixed indentation and renamed ShardsMine to FragmentMine.
sdk/packages/eternum/src/constants/resources.ts
ShardsMine
toFragmentMine
.3 files
manifest.json
Updated block number and removed loyalty model.
contracts/manifests/dev/manifest.json - Updated block number and removed loyalty model.
manifest.toml
Updated block number and removed loyalty model.
contracts/manifests/dev/manifest.toml - Updated block number and removed loyalty model.
Scarb.toml
Commented out world address.
contracts/Scarb.toml - Commented out world address.