BibliothecaDAO / eternum

onchain eternal game
https://alpha-eternum.realms.world
MIT License
36 stars 30 forks source link

change naming of fragments, hints, minor tweaks #972

Closed ponderingdemocritus closed 2 weeks ago

ponderingdemocritus commented 2 weeks ago

PR Type

enhancement, bug fix


Description


Changes walkthrough ๐Ÿ“

Relevant files
Enhancement
22 files
BottomNavigation.tsx
Cleaned up imports and updated navigation configuration. 

client/src/ui/modules/navigation/BottomNavigation.tsx - Removed unused imports. - Updated navigation configuration.
+1/-55   
MarketOrderPanel.tsx
Improved UI styling for market order panel.                           

client/src/ui/components/trading/MarketOrderPanel.tsx
  • Added hover effects and adjusted styles.
  • Enhanced market order panel layout.
  • +11/-8   
    MarketModal.tsx
    Enhanced market modal layout and added headers.                   

    client/src/ui/components/trading/MarketModal.tsx
  • Added headers for buy and sell sections.
  • Improved layout for resource listings.
  • +32/-24 
    buildings.ts
    Renamed ShardsMine to FragmentMine in building constants.

    sdk/packages/eternum/src/constants/buildings.ts - Renamed `ShardsMine` to `FragmentMine`.
    +4/-4     
    HintModal.tsx
    Added new hint sections to HintModal.                                       

    client/src/ui/components/hints/HintModal.tsx - Added new hint sections for various game aspects.
    +15/-22 
    HintBox.tsx
    Display quest rewards and adjusted styles.                             

    client/src/ui/components/hints/HintBox.tsx
  • Added quest rewards display.
  • Adjusted background color for completed quests.
  • +17/-2   
    ExistingBuildings.tsx
    Renamed ShardsMine to FragmentMine in existing buildings.

    client/src/ui/components/construction/ExistingBuildings.tsx - Renamed `ShardsMine` to `FragmentMine`.
    +8/-8     
    ArmyChip.tsx
    Reorganized and improved army information display.             

    client/src/ui/components/military/ArmyChip.tsx
  • Reorganized army information display.
  • Improved layout and styling.
  • +12/-14 
    structures.ts
    Renamed ShardsMine to FragmentMine in structure constants.

    sdk/packages/eternum/src/constants/structures.ts - Renamed `ShardsMine` to `FragmentMine`.
    +6/-6     
    ArmyInfoLabel.tsx
    Enhanced army info label with Headline component.               

    client/src/ui/components/worldmap/armies/ArmyInfoLabel.tsx - Added `Headline` component for better text styling.
    +8/-6     
    SelectPreviewBuilding.tsx
    Renamed ShardsMine to FragmentMine in building selection.

    client/src/ui/components/construction/SelectPreviewBuilding.tsx - Renamed `ShardsMine` to `FragmentMine`.
    +4/-4     
    Combat.tsx
    Added combat hint section.                                                             

    client/src/ui/components/hints/Combat.tsx - Added new hint section for combat.
    +18/-0   
    Steps.tsx
    Updated onboarding step title.                                                     

    client/src/ui/modules/onboarding/Steps.tsx - Updated onboarding step title.
    +1/-1     
    ShardsMines.tsx
    Renamed ShardsMine to FragmentMine in world map buildings.

    client/src/ui/components/models/buildings/worldmap/ShardsMines.tsx - Renamed `ShardsMine` to `FragmentMine`.
    +1/-1     
    ArmyList.tsx
    Updated army creation instructions.                                           

    client/src/ui/components/military/ArmyList.tsx - Updated army creation instructions.
    +2/-2     
    Guilds.tsx
    Added guilds hint section.                                                             

    client/src/ui/components/hints/Guilds.tsx - Added new hint section for guilds.
    +11/-0   
    TheMap.tsx
    Added map hint section.                                                                   

    client/src/ui/components/hints/TheMap.tsx - Added new hint section for the map.
    +12/-0   
    Hyperstructures.tsx
    Added hyperstructures hint section.                                           

    client/src/ui/components/hints/Hyperstructures.tsx - Added new hint section for hyperstructures.
    +11/-0   
    Points.tsx
    Added points hint section.                                                             

    client/src/ui/components/hints/Points.tsx - Added new hint section for points.
    +11/-0   
    Trading.tsx
    Added trading hint section.                                                           

    client/src/ui/components/hints/Trading.tsx - Added new hint section for trading.
    +8/-0     
    structure.cairo
    Renamed ShardsMine to FragmentMine in structure model.     

    contracts/src/models/structure.cairo - Renamed `ShardsMine` to `FragmentMine`.
    +2/-2     
    contracts.cairo
    Renamed ShardsMine to FragmentMine in map system.               

    contracts/src/systems/map/contracts.cairo - Renamed `ShardsMine` to `FragmentMine`.
    +1/-1     
    Bug fix
    1 files
    resources.ts
    Fixed indentation and renamed ShardsMine to FragmentMine.

    sdk/packages/eternum/src/constants/resources.ts
  • Fixed indentation issues.
  • Renamed ShardsMine to FragmentMine.
  • +10/-10 
    Configuration changes
    3 files
    manifest.json
    Updated block number and removed loyalty model.                   

    contracts/manifests/dev/manifest.json - Updated block number and removed loyalty model.
    +4/-235 
    manifest.toml
    Updated block number and removed loyalty model.                   

    contracts/manifests/dev/manifest.toml - Updated block number and removed loyalty model.
    +3/-20   
    Scarb.toml
    Commented out world address.                                                         

    contracts/Scarb.toml - Commented out world address.
    +1/-1     

    ๐Ÿ’ก PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    vercel[bot] commented 2 weeks ago

    The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

    Name Status Preview Comments Updated (UTC)
    eternum โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jun 21, 2024 1:16am
    github-actions[bot] commented 2 weeks ago

    PR Reviewer Guide ๐Ÿ”

    โฑ๏ธ Estimated effort to review [1-5] 4
    ๐Ÿงช Relevant tests No
    ๐Ÿ”’ Security concerns No
    โšก Key issues to review Possible Bug:
    Renaming of ShardsMine to FragmentMine across multiple files may require careful validation to ensure all references are correctly updated and no functionality is broken.
    Code Consistency:
    The PR includes a lot of UI changes and enhancements. It's important to ensure that these changes are consistent across different modules and components.
    Performance Concerns:
    The changes in the market order panel and other UI components could potentially impact performance due to increased complexity in the DOM and CSS. This should be reviewed and tested.
    github-actions[bot] commented 2 weeks ago

    Failed to generate code suggestions for PR