BibliothecaDAO / realms-contracts

Realms Monorepo for Ethereum contracts and Starknet contracts.
https://bibliothecadao.xyz/
MIT License
87 stars 33 forks source link

Feat/base64 #241

Closed ponderingdemocritus closed 2 years ago

ponderingdemocritus commented 2 years ago
  1. We store pre-encoded values in a lookup table
  2. build assembles the encoded values into an array
  3. A client can decode then concatenate the strings to build a metadata standard json to be used across marketplaces

Benefits of this:

NOTE- This is branched off the pending combat PR. Ignore those files. Only look at the new Base64 dir

milancermak commented 2 years ago

Was thinking - why base64 encode at all? It's JSON, not a binary format, so I think just data:aplication/json, ought to work.

ponderingdemocritus commented 2 years ago

this is a fair point. That makes it cleaner

ponderingdemocritus commented 2 years ago

closing as we won't use base64 for these