Armies reset to home realm after traveling

[Psyclonic]

Problem Summary: After raiding (or maybe anytime traveling is finished), army resets to "home realm".

Expected: Army can raid a realm and then raid nearby realms, without having to travel from home again.

---

Here's what I think is happening:

• Army is constructed at Home Realm. At this point, it is given no "coordinates". There is actually no way to set coordinates in the contract except for the admin, presumably indicating that coordinates are only set for permanent things, like realms.
• Army travels to another realm. During travel, travel information is set.
• Army arrives at realm and raids. Travel information is checked to verify that the army had arrived (time of arrival is checked in the travel information and that the army was traveling to the coordinates matching the realms coordinates)
• Army travels to new location. Because the army never had coordinates set, the contract defaults to the "home" coordinates. https://github.com/BibliothecaForAdventurers/realms-contracts/blob/14b16ef1b7188c43b5312968c2270c03ee53fb16/contracts/settling_game/modules/travel/Travel.cairo#L133-L137

Instead, either coordinates should be set on the army after travel is complete (in the raid or next travel command?), or the travel information should indicate the army's position after travel. This probably makes most sense for moving objects (like armies) since they should have a travel information set all the time (either they are traveling, or they have arrived and are thus past the travel time for their most recent travel information).

[ponderingdemocritus]

I think we need to set the coordinates in that statement

like:

    // if no current location set, use the home coordinates
    if (traveller_coordinates.x == 0) {
        coordinates.write(
            traveller_contract_id, traveller_token_id, traveller_nested_id, destination_coordinates
        );
        let (traveller_coordinates: Point) = get_coordinates(
            traveller_contract_id, traveller_token_id, 0
        );
        tempvar traveller_coordinates = traveller_coordinates;
        tempvar syscall_ptr = syscall_ptr;
        tempvar range_check_ptr = range_check_ptr;
        tempvar pedersen_ptr = pedersen_ptr;
    } else {
        tempvar traveller_coordinates = traveller_coordinates;
        tempvar syscall_ptr = syscall_ptr;
        tempvar range_check_ptr = range_check_ptr;
        tempvar pedersen_ptr = pedersen_ptr;
    }

So we can just set the destination in the first call - then they will have that destination when they travel again