`install-command` command is only used for installing the PR but not base revision

Bibo-Joshi / pyright-type-completeness

Composite Action to Verify Type Completeness with pyright

MIT License

1 stars 1 forks source link

`install-command` command is only used for installing the PR but not base revision #4

Closed smheidrich closed 1 month ago

smheidrich commented 1 month ago

Is there any reason why the base installation proceeds via a hardcoded pip install . -U instead of via the install-command input like the PR revision installation?

smheidrich commented 1 month ago

I actually no longer need this now that I found a different way to fix the issue I mention at the end of #5 - still curious if there is a reason why the commands should differ, though.

Bibo-Joshi commented 1 month ago

Thanks for reaching out! Nice to see that this is actually used by someone other than me :D No, there's no reason, I guess I just missed it. thanks for pointing it out and even sending a PR!