Big-Life-Lab / PHES-ODM-Validation

A toolkit to assist in validating whether data conforms to the PHES-ODM dictionary.
https://validate-docs.phes-odm.org/
Creative Commons Attribution 4.0 International
5 stars 0 forks source link

code fix for dictionary v2 release #174

Closed zargot closed 1 year ago

zargot commented 1 year ago
zargot commented 1 year ago
  1. In the assets for the schema additions specification, why did you convert everything to generate a version 1 schema?

Can you be more specific? Do you mean in test_schema_additions.py? It now tests both v1 and v2 like it should, instead of just v2.

  1. Can you update the schema additions documentation in the module-functions.qmd file?

I see that the doc says to have both parts and sets in the same odm_data_dictionary param to generate_validation_schema. I missed that part of the doc. Should I change it to be like that or is it fine the way I did it with a separate sets param?

  1. It looks like you updated the meta objects for the categories in the invalid_category rule. Can you explain why?

Yeah. Category parts don't have a catSetID any more since they were moved to the sets sheet.

  1. In the invalid_type rule assets, the bool-sets file was renamed to sets.csv. I think it makes more sense to include bool at the beginning of all the files related to that type?

Sure.

zargot commented 1 year ago

@yulric I've replied to all the comments now.