Closed yulric closed 5 years ago
Yes. comments for change. There are a few general discussion points where I wasn't sure the best change.
(Yes, re one "review". Still getting use to the PR process for GH.)
@DougManuel Done with the changes
@yulric Well, I pushed a commit to the wrong branch, but otherwise this looks good.
@DougManuel Are these all your comments for changes? Also in the future when reviewing a PR, can your make all your comments in one "review". This makes it easier for the assignee to know when to start incorporating the changes.