Big-Life-Lab / bllflow

Big Life Lab Flow (BLLFlow) - a workflow for open, reproducible research. Includes support for PMML, DDI.
https://bllflow.projectbiglife.ca
Other
11 stars 1 forks source link

[Feature] Updated summary_variables.csv #15

Closed yulric closed 5 years ago

yulric commented 5 years ago

@DougManuel Are these all your comments for changes? Also in the future when reviewing a PR, can your make all your comments in one "review". This makes it easier for the assignee to know when to start incorporating the changes.

DougManuel commented 5 years ago

Yes. comments for change. There are a few general discussion points where I wasn't sure the best change.

(Yes, re one "review". Still getting use to the PR process for GH.)

yulric commented 5 years ago

@DougManuel Done with the changes

DougManuel commented 5 years ago

@yulric Well, I pushed a commit to the wrong branch, but otherwise this looks good.