search

Big-Life-Lab / bllflow

Big Life Lab Flow (BLLFlow) - a workflow for open, reproducible research. Includes support for PMML, DDI.
https://bllflow.projectbiglife.ca
Other
11 stars 1 forks source link

Xml parsing #33

Closed rvyuha closed 5 years ago

rvyuha commented 5 years ago

Adds data from DDI object to the variableDetailsSheet

DougManuel commented 5 years ago

Add DDIwR to depends?

https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Package-Dependencies

DougManuel commented 5 years ago

Suggest moving all data in bllFlow/extdata/test-folder/ to bllFlow/extdata/. Also drop the /test-folder/DDI/. Let's just have all the data in root bllFlow/extdata.

Same for bllFlow/extdata/PBC folder.

We'll remove other RESPECT and MPoRT files from the package. Later we'll want to have separate vignette's in those repos (RESPECT and MPoRT) to demonstrate how to use those MSWs.

DougManuel commented 5 years ago

We'll need vignettes for this DDI parsing. Can you make the DDI document for the pbc data? And then use the pbc data and DDI document in the vignette. I started to create the vignette in Step 1 - model specification.

Tomorrow, I'll add to the vignette a suggestion for how we can give an example of creating the bllFlow object and import the DDI data.

DougManuel commented 5 years ago

Suggest bllFlow argument name changes: variableDetailsSheet -> variableDetails ddiXMLMetaData -> ddi

rvyuha commented 5 years ago

Suggest moving all data in bllFlow/extdata/test-folder/ to bllFlow/extdata/. Also drop the /test-folder/DDI/. Let's just have all the data in root bllFlow/extdata.

Same for bllFlow/extdata/PBC folder.

We'll remove other RESPECT and MPoRT files from the package. Later we'll want to have separate vignette's in those repos (RESPECT and MPoRT) to demonstrate how to use those MSWs.

The test - folder contains csv files that i modify on the fly to test for certain things im not sure if its a good idea to move it with the rest of the data since its purely for development atm. However i do agree with creating vignettes and relevant data folder i just dont think moving test folder data out is a good idea.

DougManuel commented 5 years ago

Suggest moving all data in bllFlow/extdata/test-folder/ to bllFlow/extdata/. Also drop the /test-folder/DDI/. Let's just have all the data in root bllFlow/extdata. Same for bllFlow/extdata/PBC folder. We'll remove other RESPECT and MPoRT files from the package. Later we'll want to have separate vignette's in those repos (RESPECT and MPoRT) to demonstrate how to use those MSWs.

The test - folder contains csv files that i modify on the fly to test for certain things im not sure if its a good idea to move it with the rest of the data since its purely for development atm. However i do agree with creating vignettes and relevant data folder i just dont think moving test folder data out is a good idea.

OK. Just remember we'll need those final vignettes for next week.