Open kittychenn opened 1 year ago
Sorry @kittychenn, I think you missed these comments,
@reikookamoto Adding you to this PR on Doug's suggestion, good to get an "outside" perspective on this feature. For some reason I can't add you as a reviewer (you don't show up when I search your username), maybe its because you're not part of the team? In any case I sent an invitation to join the GitHub team.
Can you try adding me as a reviewer now?
Reiko
On Fri, Oct 13, 2023 at 2:24 PM yulric @.***> wrote:
@reikookamoto https://github.com/reikookamoto Adding you to this PR on Doug's suggestion, good to get an "outside" perspective on this feature. For some reason I can't add you as a reviewer (you don't show up when I search your username), maybe its because you're not part of the team? In any case I sent an invitation to join the GitHub team.
— Reply to this email directly, view it on GitHub https://github.com/Big-Life-Lab/cchsflow/pull/126#issuecomment-1761993730, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBG5ZQ5N5FFQTDNHBUUPQ3X7GBOJAVCNFSM6AAAAAA4TXWYMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRHE4TGNZTGA . You are receiving this because you were mentioned.Message ID: @.***>
Adding you to this PR on Doug's suggestion, good to get an "outside" perspective on this feature. For some reason I can't add you as a reviewer (you don't show up when I search your username), maybe its because you're not part of the team? In any case I sent an invitation to join the GitHub team - Yulric
Can you try adding me as a reviewer now? Reiko
Should be there now. I think it was because you weren't a collaborator on the repo and not because you were not on the team....
@yulric I used knit to HTML to build and view the vignettes. The code sample is also available on the 'Get Started' page, so should I include it on the main page too?
@kittychenn Sorry about getting back so late. All of Reiko's suggestions look good, can you address them?
In addition I was building the website using the following commands,
devtools::document()
pkgdown::build_site()
and I'm getting an error in the getting_started.Rmd
vignette. Are you able to reproduce it?
Finally, I pushed some commits to fix some of the website build issues.
This vignette provides examples of how to harmonize variables using the full dataset. It's a good starting point to harmonize variables, but users can also implement different pipeline tools to harmonize data. Should we include pipeline methods in the example or leave it as is?