BigBoot / QCView

G3 Quick Circle for AOSP based Roms
Apache License 2.0
1 stars 7 forks source link

Circle view size and position are hardcoded #1

Open depau opened 8 years ago

depau commented 8 years ago

Hello, I'm using this app on a LG G4 h815 running CyanogenMod 13. I'm quite happy with this app, except for a simple issue: the clock is not exactly under the cover's hole. I successfully managed to move it and resize it so that it now actually matches it by editing dimens.xml from qcirclelib and replacing all other occurrences of 1046 with 1062, but now the animation is a little bit cropped on the sides and I don't know how to fix it. I think the app should not only natively detect the LG G4 and use appropriate sizes, but it should also allow the user to move around and resize the clock manually: many devices support magnetic covers (e.g. Nexus 7), and custom 3D printed hollow covers are not that hard to make. A good clock-resizing interface would allow the user to open and close the cover without the screen going on and off, and allow them to resize and move the clock using both multitouch gestures (for approximate positioning) and sliders (for exact positioning).

This is my patched dimens.xml for the LG G4 with the cropped animation issue:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <dimen name="config_circle_diameter">1062px</dimen>
    <dimen name="config_circle_window_height">1062px</dimen>
    <dimen name="config_circle_window_x_pos">197px</dimen>
    <dimen name="config_circle_window_y_pos">16px</dimen>
</resources>```