BigBrotherBot / big-brother-bot

Big Brother Bot B3 is a complete and total server administration package for online games. B3 is designed primarily to keep your server free from the derelicts of online gaming, but offers more, much more.
http://www.bigbrotherbot.net
148 stars 143 forks source link

[BF4] add game support #97

Closed ozon closed 10 years ago

ozon commented 11 years ago

DICE has not released any documentation. But I open this issue to avoid future parallel developments.


Edit by Courgette:

Please use this issue for synchronizing efforts between those who which to contribute on the BF4 parser.

ressources

thomasleveil commented 11 years ago

Do you feel up to the task ? The goal would be to implement the BF4 parser while minimizing the number of lines changed to the BF3 parser.

ozon commented 11 years ago

I got the Server docs now and can start coding. After a short overview, I would say that has not changed much. Ideas to the FairFight system?

Dwarfer commented 11 years ago

Hi, I have a server up and running at the moment with a base mod to the BF3 parser, trying to work out how todo a pull to then upload my version as a base.

Dwarfer commented 11 years ago

Hi, If you look at https://github.com/BigBrotherBot/big-brother-bot/pull/101 this has the initial working parser, it is going to need more work but does work as of now.

ozon commented 11 years ago

Hm....just work on the parser too in this moment.

My GSP say that server go today online. Whatever. I plan to push my changes if all stuff working - includes /test/* and a live test.

Dwarfer commented 11 years ago

Hi,

Just do a merge/pull of mine its already done and working no point doing it twice :-)

ozon commented 11 years ago

@Dwarfer, you have some issues in your code. As example; vars like ranked or bannerUrl are removed. Some new vars like commander are missed. I have no interest to merge your code and correct errors.

In addition, I try to document the changes so that plugin developers have it easier to port plugins. Other issues must also be addressed. As example, how we handle the 'official' and 'ranked' mode. The 'official' mode dosnt allow kick/ban players.

Dwarfer commented 11 years ago

@ozon, I know there are still some items missing and those seem to be "un documented" like the bannerURL is and are still there as can be clearly seen here http://battlelog.battlefield.com/bf4/servers/show/pc/bd70325f-2a95-4046-b255-57e9cbe75e45/. I know its supposedly a "known issue" but it would seem that the bannerURL is not going away just maybe changing the name slightly (from my sources) I can also already see that some of the new vars documented don't work and throw up an UnknownCommand in B3 and Procon.. So I would not take what the Admin Document for gospel at this stage :-)

Don't forget that the initial rcon documentation is/was lacking for BF3 when it came out and we had the same fun then doing the port/setup. from my experience with the BF2, BF3 and more than likely BF4 release we will see some changes again within the first 2-4 weeks and will probably have to start again :-)...

As it stands now myself and I know allot of other admins are more interested in having B3 working so we can track, record and warn players and from what I can see at the moment (just kicked a player with the telnet plugin) things are working like that with my MOD.. is it a long term MOD probably not, does/will it work to serve the current needs for B3 in BF4 YES (from my testing)

thomasleveil commented 11 years ago

Hi guys,

It is nice to see different persons willing to help with the BF4 support in B3 :)

If you are to share work between the two of you (or more persons) there will be need for a bit of coordination so one does not code the same feature as the other did. If you want you can use the github issues to document the different subtasks to be done for BF4.

A few things to be aware of:

thomasleveil commented 11 years ago

@ozon @Dwarfer : what should I do with pull request #101 ?

Can you both agree on how to get started with the BF4 parser and tell me which pull request to merge first ? It is OK to send pull requests for BF4 even before it is entirely done.

side note: I've updated the 1st post of this issue with a link to a BF4 rcon support forum where at least one of the DICE employees is lurking.

ozon commented 11 years ago

You force me to publish unfinished code..... that destroy all my plans :( My branch; https://github.com/ozon/big-brother-bot/tree/features/bf4_parser

Dwarfer commented 11 years ago

OK, Well if you going to base off this then fine, however you need to change the following

You need to change line 41 from this to that

BF4_REQUIRED_VERSION = 1149977

BF4_REQUIRED_VERSION = 86637

Re force well as I said mine was just to get it working you can/could still go and complelty re change when your ready then publish but either way OK.

ozon commented 11 years ago

The R7 server patch fixes some thinks - c1302364706eff98ec4fbde8f26d55048513997d. There were and are issues that we should check.

  1. ~~Player GUID should now be correctly set when joining from the server queue I had not noticed the problem. But it begs the question, how did B3 deals with the problem? Maybe corrupted database entries? In my case, some users are missing the PBID's. (Not sure if that is really a problem or if this updated by B3 later.)~~
  2. ~~A user in the fpsadmin forum noticed that the serverinfo string miss some details if the game mode is rush. http://www.fpsadmin.com/forum/showthread.php?t=25370~~
ozon commented 10 years ago

The BF4 parser is on par with the BF3 parser. B3 supports BF4.