BigBrotherTeam / BigBrother

Allows the connection of Minecraft: Java Edtion clients to PocketMine-MP servers. Made for PocketMine-MP
GNU Lesser General Public License v3.0
96 stars 23 forks source link

increase color conversion performance x94 faster (in single thread) #142

Closed eternalharvest closed 5 years ago

eternalharvest commented 5 years ago

Introduction

This change-set introduce the pre-calculated color index to increase color conversion performance which was introduced by PR #141.

Requirements

Follow-up

still heavy even if this patch is applied when u have a lot of item-frame and filled-map inside of it. because ClientboundMapItemData packet decoding costs is very high!! It will instantiate Color for each pixel.

eternalharvest commented 5 years ago

sorry, don't merge this! i need to confirm this...

eternalharvest commented 5 years ago

I fixed the problem of original PR i posted. And then, i cleaned up history and push force again. From now on, this patch is ready to merge!