search

BigDataWUR / AgML-CY-Bench

CY-Bench (Crop Yield Benchmark) is a comprehensive dataset and benchmark to forecast crop yields at subnational level. CY-Bench standardizes selection, processing and spatio-temporal harmonization of public subnational yield statistics with relevant predictors. Contributors include agronomers, climate scientists and machine learning researchers.
https://cybench.agml.org/
Other
9 stars 3 forks source link

DE data differences #163

Closed krsnapaudel closed 1 month ago

krsnapaudel commented 1 month ago

The overview table currently says that the EU data source has DE data at admin level 1. Actually the data is at admin level 3 (NUTS3). The same is true for DE data source onboarded by @CarlaLimone. Identify differences between the two sources and indicate which we should use.

krsnapaudel commented 1 month ago

I see that some data in JRC file disappears when we do coherence checks. Please check if this is the same for DE source onboarded by @CarlaLimone. Please complete this today. Thanks.

Amit1979-UniBonn commented 1 month ago

Dilli, I checked, it's ok. However, in the final file, name of the districts has not been included. If it was decided like that, then its ok.

Amit1979-UniBonn commented 1 month ago

perhaps it's not important to include the district names since nuts_id/adm_id is there, it can be used for aggregation when required

Amit1979-UniBonn commented 1 month ago

ok,.Tomorrow the first thing I will do after reaching the office is creating a Footnote in README.md file and add explanation/rationale for using DE data opposed to EU datasource, and Commit. Thanks for your understanding.

With Best Regards, Amit

On Mon, May 27, 2024 at 8:42 PM Dilli Raj Paudel @.***> wrote:

@Amit1979-UniBonn https://github.com/Amit1979-UniBonn : You cannot close an issue without fixing it. Please add notes to the README.md. See a footnote about DE data.

— Reply to this email directly, view it on GitHub https://github.com/BigDataWUR/AgML-crop-yield-forecasting/issues/163#issuecomment-2133927907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOUXLDRV5DWAEO6X4CKXO7TZEN5A3AVCNFSM6AAAAABH3WKESKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHEZDOOJQG4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Amit Kumar Srivastava

krsnapaudel commented 1 month ago

Merged with #229