search

BigE / desk-changer

Gnome-Shell wallpaper changing extension with multiple profile support
MIT License
78 stars 14 forks source link

Error on Gnome 3.37.90 #70

Closed raushankumar27 closed 3 years ago

raushankumar27 commented 4 years ago

On Gnome 3.37.90 ubuntu 20.10 development branch

Extension failed to start Error log: JS ERROR: Extension desk-changer@eric.gach.gmail.com: TypeError: meta is null _patchContainerClass/containerClass.prototype.child_set@resource:///org/gnome/shell/ui/environment.js:43:13 _patchContainerClass/containerClass.prototype.add@resource:///org/gnome/shell/ui/environment.js:52:18 _init@/home/master/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/ui/popupMenu.js:52:14 _init@/home/master/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/ui/panelMenu.js:33:31 enable@/home/master/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/extension.js:120:14 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:168:32 loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:349:26 callback@resource:///org/gnome/shell/ui/extensionDownloader.js:234:39 gotExtensionZipFile/<@resource:///org/gnome/shell/ui/extensionDownloader.js:115:13

raushankumar27 commented 4 years ago

https://github.com/raushankumar27/desk-changer/commit/22a0ebff34866e3c8c833be8e881d03fc781ed10 After this change it seems to be working fine

Gowee commented 4 years ago

I encounter the same error on GNOME 3.38:

10月 06 10:07:26 hostname.redacted gnome-shell[125919]: init desk-changer@eric.gach.gmail.com version 18
10月 06 10:07:26 hostname.redacted gnome-shell[125919]: JS ERROR: Error: Wrong type undefined; string expected
                                                       _emit_preview@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/profile.js:216:14
                                                       fill_queue@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/profile.js:129:14
                                                       next@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/profile.js:163:14
                                                       _init/this._loaded_id<@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/server.js:168:41
                                                       load@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/profile.js:151:14
                                                       load@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/profile.js:367:22
                                                       start@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/daemon/server.js:205:30
                                                       enable@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/extension.js:77:16
                                                       _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                                       loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:348:26
                                                       _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:586:18
                                                       collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:28
                                                       _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:565:19
                                                       _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:595:18
                                                       _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:626:18
                                                       init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14
                                                       _initializeUI@resource:///org/gnome/shell/ui/main.js:269:22
                                                       start@resource:///org/gnome/shell/ui/main.js:159:5
                                                       @<main>:1:47
10月 06 10:07:26 hostname.redacted gnome-shell[125919]: JS ERROR: Extension desk-changer@eric.gach.gmail.com: TypeError: meta is null
                                                       _patchContainerClass/containerClass.prototype.child_set@resource:///org/gnome/shell/ui/environment.js:43:13
                                                       _patchContainerClass/containerClass.prototype.add@resource:///org/gnome/shell/ui/environment.js:52:18
                                                       _init@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/ui/popupMenu.js:52:14
                                                       _init@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/ui/panelMenu.js:33:31
                                                       enable@/home/lotus/.local/share/gnome-shell/extensions/desk-changer@eric.gach.gmail.com/extension.js:120:14
                                                       _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:167:32
                                                       loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:348:26
                                                       _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:586:18
                                                       collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:28
                                                       _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:565:19
                                                       _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:595:18
                                                       _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:626:18
                                                       init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14
                                                       _initializeUI@resource:///org/gnome/shell/ui/main.js:269:22
                                                       start@resource:///org/gnome/shell/ui/main.js:159:5
                                                       @<main>:1:47
Gowee commented 4 years ago

After manually patching the changes of raushankumar27@22a0ebf, the TypeError: meta is null error goes away while the Error: Wrong type undefined; string expected error is still there.

Update: The latter error does not really matter. Desk Changer works well as normal after applying the above patch.

Gowee commented 4 years ago

I just notice that there is a same problem here in https://github.com/biji/simplenetspeed/issues/19, according to which the property name {x,y}_fill has been deprecated in favor of {x,y}_expand. Manully renaming the property works for me.

BigE commented 4 years ago

The changes made seem to fix the issue, which is switching add to add_child as seen here https://github.com/elvetemedve/gnome-shell-extension-system-monitor/commit/416914aa63cd368c9151cad88a1c5e3bb25340a2#diff-63b90efa78479af5e0e11771d87386c60abb31047d09472ab1178705e4a3faedR179

I'm currently in the middle of a full daemon rewrite, so I don't totally have the resources or time to test this fully and release a new version, but using the develop branch should make things work again. Thanks for the report! I'll officially close this once I've made a release with the fix in it.

BigE commented 3 years ago

This should be fixed by the Version 30 release. If you continue to experience issues, please open a new issue with new details. Thanks!