search

BigETI / SAMPLauncherNET

SAMPLauncherNET is a launcher for San Andreas Multiplayer
GNU General Public License v3.0
72 stars 18 forks source link

Not properly refreshing favorites #58

Closed markski1 closed 5 years ago

markski1 commented 5 years ago

Not sure if related to the latest update, but this started happening this morning. Only instruction to reproduce is to open the client. Sometimes some of the pings are updated but the rest of the information isn't shown until you click on a server.

2018-12-13_11-11-18

Note this only happens with favorites. Online listings work fine (except for southclaws and official which do not load at all)

BigETI commented 5 years ago

Not sure what happened there. Your client might be timed out while querying all the servers in your list. Your favourites.json should have stored the hostnames of each server anyway.

Southclaws API domain has changed. Just revert the API settings in the API tab and it should fix that. The official server list is a remainder from older SA:MP versions. It does not exist for never SA:MP versions anymore.

Edit: Looks like that https://api.samp-servers.net/v2/servers responses with 403 to the client.

markski1 commented 5 years ago

Happens consistently when opening the client. Will try again later to see if it keeps happening.

BigETI commented 5 years ago

Tell me if https://github.com/BigETI/SAMPLauncherNET/commit/33e8e8fa216e2833d0f394891f3dd999241a94b5 fixes the mentioned issues.

markski1 commented 5 years ago

imagen Looks fixed-ish, sometimes it doesn't query some information but the name is always there, which is good enough.

BigETI commented 5 years ago

I might change some things again and I will come back when they are done. Thank you!

BigETI commented 5 years ago

Please tell me if https://github.com/BigETI/SAMPLauncherNET/commit/a98b982c0c0cb421f744cee8f9042b0fc893ae8c solves the mentioned issues properly.

markski1 commented 5 years ago

The issues were resolved. It has also greatly reduced the CPU usage.