search

BigEd / python-on-a-chip

Automatically exported from code.google.com/p/python-on-a-chip
Other
1 stars 3 forks source link

Fix non-constant expression in array length declaration in strobj.c #73

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Compiling the VM for windows and PIC ports.
2.
3.

What is the expected output? What do you see instead?
Expect to compile without error. Get:  error C2057: expected constant 
expression    c:\Users\bjones\Documents\svns\python-on-a-
chip_trunk\src\vm\strobj.c    253

Original issue reported on code.google.com by dwhall...@gmail.com on 11 Mar 2010 at 7:52

GoogleCodeExporter commented 9 years ago 
Instead of using a temporary buffer to create a concatenated C string, I 
duplicated the 
actions of string_create() to create a string object of appropriate size.  It 
was not 
possible to call string_create() because of the way which the string cache 
works.

No system test would be able to detect regression.  System test t242 tests 
Python 
string concatenation.

Original comment by dwhall...@gmail.com on 11 Mar 2010 at 11:59

GoogleCodeExporter commented 9 years ago 
System tests pass.  Mainlined directly, see r452

Original comment by dwhall...@gmail.com on 12 Mar 2010 at 12:00

GoogleCodeExporter commented 9 years ago 
Changed r09 to R09

Original comment by dwhall...@gmail.com on 12 Mar 2010 at 8:22

GoogleCodeExporter commented 9 years ago

Original comment by dwhall...@gmail.com on 13 Mar 2010 at 1:30