Closed GoogleCodeExporter closed 9 years ago
Dean,
Would you like me to go ahead and mainline these changes? Seems like they got
orphaned.
Bryan
Original comment by bjones460@gmail.com
on 25 Mar 2010 at 3:04
r476:
- Incorporated Tyler's changes
- A bit of code formatting
- Changes in comments above included
Original comment by bjones460@gmail.com
on 26 Mar 2010 at 4:20
One remaining issue:
warning C4244: 'function' : conversion from 'uint16_t' to 'uint8_t', possible
loss of
data c:\Users\bjones\Documents\svns\python-on-a-chip_trunk\src\vm\img.c 117
pymite
It appears that img.c line 117 calls img_findInPath. The second parameter is
string
length, from a pPmString_t->length field, which is a uint16_t. However, the
parameter
accepts only a uin8_t.
Suggested fix:
- C_ASSERT that the string's length does not exceed 255 bytes
- Cast the argument in the function call
Original comment by bjones460@gmail.com
on 26 Mar 2010 at 4:23
Copied from Tyler's svn log:
r558
- Enable the HAVE_DEBUG_INFO flag that was added for Issue #103
- Update Visual Studio project files, adding versions for VS 2010 Express and
renaming older ones
for VS 2008
- Adjust the py2c.bat file to work without warnings under cygwin
(tested under cygwin 1.7.5)
- Adjusted VS projects to place resultant executable (main.exe) under
platform/windows root. This
includes all Release and Debug versions. Note this requires an updated ipm.py
- Remove plat.obj from subversion. Should not be there.
Mainlined directly
Original comment by dwhall...@gmail.com
on 12 Aug 2010 at 2:34
Tyler did the work. Copied from Tyler's svn log:
r559
- Quick fix for the VS2008 project: not putting the .exe in the right place.
- Quick fix for the VS2010 project: missing the .filters file, which creates
the folders in the VS2010 GUI.
Original comment by dwhall...@gmail.com
on 12 Aug 2010 at 2:35
Original issue reported on code.google.com by
dwhall...@gmail.com
on 12 Mar 2010 at 7:58