Upgrading to D3V6 - Githubissues

BigFatDog / cubism-es

ES6 module of cubism.js, based on d3v5.

MIT License

23 stars 8 forks source link

Upgrading to D3V6 #8

Open Fallstop opened 3 years ago

Fallstop commented 3 years ago

The latest version of cubism-es is incompatible with the latest D3 library version realised last September, namely one of the issues is the API change around d3-selection new event manager (d3.mouse -> d3.pointer).

Is there a plan to upgrade? If wanted, I can submit a pull request with the changes necessary to both the library and demos.

Fallstop commented 3 years ago

Because of the lack of activity, I'll just go ahead and attempt to do it myself.

BigFatDog commented 3 years ago

Thank you. Once you make a pull request I'll merge it.

aspiers commented 3 years ago

Any update on this @Fallstop? I'd be happy to test.

Fallstop commented 3 years ago

Sorry! Completely forgot about this. It's mostly done as there was not a lot of API changes, but my testing method is very jank. Is there an example repo that I could use to test the changes?

aspiers commented 3 years ago

You can presumably use the demos in this repo: https://github.com/BigFatDog/cubism-es/tree/master/demo

Fallstop commented 3 years ago

That's what I thought too. But those are all using DISCRETE CUBISM.JS, a modified version of the original cubism, and don't use cubism-es.

aspiers commented 3 years ago

That's not correct:

Only demo/discrete-cubism.html is using demo/discrete-cubism.js; none of the others are.
demo/discrete-cubism.js is not a modified version of the original cubism, it's some code specific to the discrete-cubism demo, and that demo, like all the others uses cubism-es:

https://github.com/BigFatDog/cubism-es/blob/c8dd327e549148c29fcfed86c38bbd4748018937/demo/discrete-cubism.html#L20

throrin19 commented 2 years ago

Any news ?

mpatou commented 6 months ago

@Fallstop can you push your work in progress in your repo ?

ekacnet commented 6 months ago

I made a few commits in my fork to:

update dependencies: https://github.com/ekacnet/cubism-es/tree/update_deps
update d3: https://github.com/ekacnet/cubism-es/commits/update_d3
add github actions: https://github.com/ekacnet/cubism-es/tree/add_github_actions

I don't know how much @BigFatDog is still active on this project if not active I might end up publishing something on npm on my own.

ekacnet commented 6 months ago

All my changes are available in my dev branch on: https://github.com/ekacnet/cubism-es/tree/dev.