search

BigFatDog / parcoords-es

ES6 module of Syntagmatic's Parallel Coordinates
MIT License
62 stars 32 forks source link

fix lingering issues from #57 following @timelyportfolio's approach #61

Closed joshhjacobson closed 5 years ago

joshhjacobson commented 5 years ago

I was still having issues when an array of axes that included the rightmost axis was hidden. This gave the error TypeError: Cannot read property 'type' of undefined from this line in brushFor.js:

brushRangeMax = config.dimensions[axis].type

I followed the same approach released in v2.2.5 to correct this.

joshhjacobson commented 5 years ago

@BigFatDog sorry to bother you, but is there any way we can get this PR merged in the next few days? I have a deadline coming up at the end of the month and it would be great to have this fixed by then.

BigFatDog commented 5 years ago

@joshhjacobson Don't worry. I do it right now.

joshhjacobson commented 5 years ago

Hi there, just wanted to check in on this. Any chance you'd be able to merge this in the next day or two? If there are revisions that need to be made, please let me know. Thanks!

BigFatDog commented 5 years ago

I've been waiting for your response for the pending code review these days. as I said in the end of review:

Please also don't worry this discussion would block your work. I'll merge ASAP once we have a conclusion.

If we reach a conclusion, I'll do this tonight.

joshhjacobson commented 5 years ago

My bad, I didn't realize you'd already completed a review. Where can I find that?

BigFatDog commented 5 years ago

Oh MY GOD! I didn't submit it...

Sorry, my bad.

BigFatDog commented 5 years ago

v2.2.7 has been published to deliver this PR.

Thank you for your time and efforts! Good night. 🌔

joshhjacobson commented 5 years ago

Much appreciated!

timelyportfolio commented 5 years ago

@joshhjacobson @BigFatDog thanks so much. Sorry I missed that!

joshhjacobson commented 5 years ago

@timelyportfolio no problem! Wouldn't have been able to figure this out without your initial fix.

BigFatDog commented 5 years ago

Much appreciated!

You're welcome.

BigFatDog commented 5 years ago

@joshhjacobson @BigFatDog thanks so much. Sorry I missed that!

It's fine. Please don't worry about it.