BigFatDog / parcoords-es

ES6 module of Syntagmatic's Parallel Coordinates
MIT License
62 stars 32 forks source link

Resize fixes in a sibling fork #73

Open ajbouh opened 5 years ago

ajbouh commented 5 years ago

@BigFatDog Thanks for this awesome port! I'm trying to embed parcoords-es in a way that supports resizing, brushing, and updating data. The combination of these three creates problems for me when using brush modes "1D-axes" and "1D-axes-multi".

It seems like some of this may be addressed by https://github.com/autodesk-forks/parallel-coordinates/pull/1 and other recent commits in https://github.com/autodesk-forks/parallel-coordinates.

Is there any interest in trying to pull over these fixes? Or has the code diverged too much for that to be helpful?

BigFatDog commented 5 years ago

Hi @ajbouh Thank you for your appreciation. The autodesk fork that you mentioned are based on the original parallel-coordinates therefore that pull request cannot be applied to parcoords-es directly. Yes, the code has diverged too much. I see two approaches here:

Currently I tend to adopt approach #2 because if autodesk would like to contribute, they would do it for all enhancements rather than this single feature.

I'll keep you updated here when I start.