BigFatDog / parcoords-es

ES6 module of Syntagmatic's Parallel Coordinates
MIT License
62 stars 32 forks source link

Delegate styling to css #77

Open jvmanke opened 5 years ago

jvmanke commented 5 years ago

Currently it is not possible to change axis stroke color through css.

In the parcoords.css such css property is set to a default, but it has no effect because these properties are set with d3s .style() function, having priority over css.

The values set through javascript are the same as the ones on the css sheet leading me to believe they are set as defaults.

Some of these properties are merely stylistic in nature, which could be useful if configurable (through css specialy), however some of them could be tied to the shape of the plot.

I could find some properties that could outsourced solely to the css sheet making them instantly configurable:

Stroke and Fill in: (maybe shape-rendering) https://github.com/BigFatDog/parcoords-es/blob/dfd8d021d763a1bf2a089b3df4a9f70b33f6909e/src/api/createAxes.js#L47-L57 https://github.com/BigFatDog/parcoords-es/blob/dfd8d021d763a1bf2a089b3df4a9f70b33f6909e/src/api/updateAxes.js#L32-L42

Font in: https://github.com/BigFatDog/parcoords-es/blob/dfd8d021d763a1bf2a089b3df4a9f70b33f6909e/src/api/init.js#L33-L38