search

BigJk / snd

Sales & Dungeons — Thermal Printer as D&D / TTRPG Utility
https://sales-and-dungeons.app/
MIT License
474 stars 17 forks source link

False Positive Trojan Warning on Windows #28

Closed Brazier85 closed 1 year ago

Brazier85 commented 1 year ago

Hello, on startup windows defender is blocking your application with the following message:

image

Can you pls take a look into this issue or can you tell me what the leakless.exe file is?

BigJk commented 1 year ago

Hello Brazier,

never heard of anyone experiencing a trojan warning so far.

I dug a bit and leakless is a utility (https://github.com/ysmood/leakless) to "Run sub-process and make sure to kill it when the parent process exits.". It is used by https://github.com/go-rod/rod which S&D uses to control a chrome instance to create images from HTML. It's probably used to make sure that all sub-processes are killed correctly if rod shuts down.

Does this information help?

BigJk commented 1 year ago

Related Issues:

https://github.com/go-rod/rod/issues/739 https://github.com/go-rod/rod/issues/720 https://github.com/go-rod/rod/issues/734

Brazier85 commented 1 year ago

okay, thank you. I will recover the file and ignore the alert :)

BigJk commented 1 year ago

As of v0.6.3 leakless is explicitly disabled on windows. I hope this will avoid any further false positive warnings 👍