BigMacintosh / Parking

Year 3 Games Project

MIT License

6 stars 0 forks source link

End of Game Logic Finally Fixed #224

Closed ChrisGora closed 4 years ago

ChrisGora commented 4 years ago

Fixed the game logic so that the Game always ends when we expect it to. Turns out Round Manager was correct, Parking Manager a bit less so.

The Game correctly ends but the disconnect does not happen.

Smaller changes:

Client and Server Parking Managers are their own files.
The HUD no longer shows any placeholders (and appears to work correctly all the time).

Resolves #198 Made some progress on #199

197 is not done

RileyEv commented 4 years ago

Okay so for this is it just that the Server isn't handling the game end event correctly?

RileyEv commented 4 years ago

Does the eliminating player stuff work now too? or is that just a disconnect problem too 🙈

ChrisGora commented 4 years ago

Just tested this. So, in a round with 3 players:

2 Players claimed a space.
The player without a space gets despawned but not disconnected.
An exception happened, see #226
Round Ended
The other 2 players continued in a new round
Neither of them claimed a space
They both got told they lost (but they don't appear despawned nor disconnected)
(and the server doesn't start another round which it did before)

TLDR It all works

RileyEv commented 4 years ago

There is a chance, I changed it so that players aren't disconnected anymore 🤔 because they'll turn to police cars. But need to check that one in a minute