dominictayloruk
commented
2 years ago Might be better to query Band protocol for aggregate prices https://data.bandprotocol.com/
Closed kevincaradant closed 2 years ago
dominictayloruk
commented
2 years ago Might be better to query Band protocol for aggregate prices https://data.bandprotocol.com/
kevincaradant
commented
2 years ago It could be an idea. However, in the mean time, @BigNocciolino could you please increase a little bit more the time. 60s => 120s. Not sure we have to know every minute the exact price :D. Thanks
Edit: Other solution maybe better. if your received a 429. You don't update the graph and keep the last number. Put a mini logo maybe like !WARN! which mean as tooltip (Last value didn't receive) but I just don't want to have "NaN" as value :)
BigNocciolino
commented
2 years ago Interesting point, for the moment I increase the delay. These days I try to find a better way to handle this error.
itkama
commented
2 years ago I tried changing the delay to 120s myself in the files. Still seems to be having problems. Maybe the cryptonator-API has problems with too many requests from one source at once?
kevincaradant
commented
2 years ago Hi @itkama, Indeed I think the api doesn't support for the moment the huge amount of requests. Increase to 120 is not the final solution for me but it will avoid a little bit the issue to have NaN as value instead of a number. It's will reduce the risk but not eliminate it :) It's just to let the time to @BigNocciolino to manage the 429 issue skipping it without break the current value for each crypto
tborges
commented
2 years ago Hey, pretty cool app. I'm getting a bunch of these 429 errors lately while I'm using the Cryptonator app. I guess they did change something on their API? Because I wasn't getting these errors before.
BigNocciolino
commented
2 years ago Hi, I wrote some code that should have fixed it.
I have published a pre-release as I would like to wait longer to determine if the problem has been fixed or not.
In time, if anyone wants to try the new version, just enable the trial versions in hacs.
EDIT: For a detailed trace see: #18
itkama
commented
2 years ago @BigNocciolino seems to be working great so far with the pre-release-version :)
kevincaradant
commented
2 years ago Is it working because for me, its really dead 😂 I'm running on the alpha and latest version.
BigNocciolino
commented
2 years ago Hi, this is a problem related with the api itself, please see: #15 This is very frustrating :|
kevincaradant
commented
2 years ago Just because I updated your plugin? Before this, I got many requests successfully. Now I don't have any error but no request at all. No values neither error on logs. It happens just after the update :)
Are we agree that you didn't change anything about configuration ? A simple upgrade to alpha version should works ? :)
BigNocciolino
commented
2 years ago This is not a problem related with the update sience i can not reach the api with: (This is just a very precise coincidence)
EDIT: The component worked for a little, (i tested it, before pushing all the changes) and then the api went down.
[alfonso@Fisso ~]$ wget https://api.cryptonator.com/api/ticker/btc-usd
--2022-02-04 20:07:15-- https://api.cryptonator.com/api/ticker/btc-usd
SSL_INIT
Caricato certificato CA "/etc/ssl/certs/ca-certificates.crt"Risoluzione di api.cryptonator.com (api.cryptonator.com)... 104.22.63.82, 172.67.10.138, 104.22.62.82, ... Connessione a api.cryptonator.com (api.cryptonator.com)|104.22.63.82|:443... connesso. Richiesta HTTP inviata, in attesa di risposta... 503 Service Temporarily Unavailable 2022-02-04 20:07:15 ERRORE 503: Service Temporarily Unavailable.
- **Postman:**
But from the browser we can access, this is the same problem of #15 Oh alright :(. Indeed, I tested in the browser but didn't try on Postman, I understand. So I will wait
kevincaradant
commented
2 years ago @BigNocciolino , I tried the V2.0.0 but I didn't understand how can I tried ?
Is it a good setup ? WIth the black theme I don't see tooltips or whatever on the first and second field so I put something ramdomly ;)
BigNocciolino
commented
2 years ago Hi, the setup is good, but let me explain what this parameters are:
All these values can be found on the api page
Hope this is useful.
kevincaradant
commented
2 years ago Hi, the setup is good, but let me explain what this parameters are:
- Crypto: Here you can insert the code of the crypto (like "btc", "ada")
- Base: Here you can enter the code of the currency or cryptocurrency with which you want to convert the value above.
All these values can be found on the api page
- Name: Here you can insert a friendly name, this will change the name of the sensor. (like "bitcoin", "dogecoin")
Hope this is useful.
Yes Indeed, i mean it's clear, thank you.
However, it seems it doesn't work yet ^^. Maybe it's normal ?
BigNocciolino
commented
2 years ago Hi, are there any logs coming from the component?
kevincaradant
commented
2 years ago I got some issues with HA, by consequence, some logs are not clear...
The only things I saw is [homeassistant.config_entries] Error unloading entry xrp for cryptostate Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 466, in async_unload result = await component.async_unload_entry(hass, self) File "/config/custom_components/cryptostate/init.py", line 75, in async_unload_entry unloaded = await asyncio.gather( File "/usr/local/lib/python3.9/asyncio/tasks.py", line 826, in gather if arg not in arg_to_fut: TypeError: unhashable type: 'list'
But I will clean and wait to see if there is any other logs
BigNocciolino
commented
2 years ago Hello, with the new release both the problems related to the configuration and to the component itself should be solved.
kevincaradant
commented
2 years ago For the moment, no error but always NaN as values ;) Edit: I was on alpha 3 but just saw alpha 4 now, it was not here 2 hours ago :P. I will try
Edit 2: Much better it works :)
Is it possible to have already now like before the graph with color ect ?
It's seems I got only the number
kevincaradant
commented
2 years ago I got it, why I don't have a graph like before. It's just because the api used, can have a scan only every 12h or 24h but not every minute like before. Not a big deal but got it every 6 hours would be better 😁. Anyway thanks, I will try to setup this for each crypto, next week
BigNocciolino
commented
2 years ago Hi I'm closing all the old issues, if there are problems with the new version, please open a new issue
Hi
As you ask me @BigNocciolino , I created a new issue because it still happens. Maybe less often but it still happens with the latest version.
I can see in live, when EGLD has a value, bitcoin becomes "NaN". When BTC have a value, SOL becomes "NaN" ect :P
Maybe a pooling every 2 minutes could fix the issue ? I don't know how many requets are allow by hour / day but I have 10 cryptos loaded so it realized 10 requests by minute in my case.
Regards
NB: The complete logs: