BigNoid / Aeon-Nox

A skin for XBMC/Kodi
Other
255 stars 187 forks source link

Incorrect Rating graphics being displayed instead of BBFC graphics #579

Closed xyzlabc closed 11 years ago

xyzlabc commented 11 years ago

I have noticed that on any films where a BBFC (British Board of film Classification) Rating has been downloaded, Aeon Nox is instead displaying a German FSK logo or MPAA Not Rated Logo. I checked in another skin, Transparency, and the scraper is definitely downloading the correct ratings.

(Edit: Films rated U, which isn't present in MPAA or FSK are coming up with an MPAA "Not Rated sign")

I'm using the repo version of Aeon Nox on XBMC 12.0.

The attached screenshots show the issue. Notice how Transparency lists the rating of Woman In Black as 12A (a rating that is exclusive to BBFC) wheras Aeon Nox lists the rating as FSK 12. (Ignore the part in Transparency about MPAA).

Also, American Werewolf In London has a BBFC rating of 18, but an FSK rating of 16, but is displayed as FSK 18 in Aeon Nox, confirming that the correct rating is being downloaded from The Movie DB.

screenshot024 Transparency confirming that the BBFC Rating of 12A was downloaded, not the FSK rating

screenshot025 Aeon Nox displaying the FSK Rating 12.

screenshot023 Aeon Nox displaying FSK 18, even though the BBFC 18 rating was downloaded. It might be worth noting that the correct FSK rating for this film is 16, so the FSK rating hasn't been downloaded aswell.

screenshot027 My Neighbour Totoro displays with a U rating in Transparency, showing that the scraper has downloaded it.

screenshot026 However, in Aeon Nox it displays with an MPAA Not Rated symbol.

Obviously, it could be happening with PG aswell, since PG is present in both BBFC and MPAA, but there's no way of knowing since the scraper falls back to MPAA if it can't find a BBFC rating.

BigNoid commented 11 years ago

Instead of prefixing the rating with "Rated" you should prefix it with "UK:" for Nox to display UK ratings.

xyzlabc commented 11 years ago

Oh, sorry. I am using The Movie Database scraper, which didn't have that option. I now realise that it is in Universal Movie Scraper, so I'll switch to that. Thanks for clarifying, but what about for ratings that aren't UK, and get downloaded when the UK one isn't available?

xyzlabc commented 11 years ago

Adding "UK:" or "UK: " doesn't seem to display the rating in Aeon Nox correctly either. Any suggestions? I'm trying this with "My Neighbour Totoro" which is Rated U.

BigNoid commented 11 years ago

The ratings we search for must have for example "UK:U" in the string. So "Rated UK:U" should work also. The important bit is "UK:U"

BigNoid commented 11 years ago

you can of course modify the skin to show the correct ratings. Might be simpler then rescraping. In variables.xml search for UK: and chang that to your needs.

xyzlabc commented 11 years ago

I've decided that I'll just re-scrape as it will be easier for me to remember to do if I do a complete re-install of anything further down the line.

It appears to be working now. Is there anyway that a "Rating country" or similar setting (accessible via the GUI) could be integrated into Aeon Nox in the future? So people could select that they want BBFC ratings, and then Nox only looks for them, and the rating prefix does not matter?