BigNoid / Aeon-Nox

A skin for XBMC/Kodi
Other
254 stars 187 forks source link

Hide toast notifications during video playback #674

Open techmunk opened 8 years ago

techmunk commented 8 years ago

Hi,

I wanted to be able to hide toast notifications during video playback, as they annoyed me. I was able to achieve this with:

<visible>![Player.Playing() + Player.HasVideo()]</visible>

in DialogKaiToast.xml, in the group control.

Is this something that would be of interest?

I had a quick look into making it a configuration option, and it seems easy enough, though, the localisation stuff scared me away. I have no idea how to translate "Disable Toast's during video playback" into Russian for example.

Happy to make a pull request with just the above, or a config option. I just can't make the translations.

Is this of interest? Can this be done?

BigNoid commented 8 years ago

I don't think hiding the notifications is a good idea at this point as there's no real way to read them back. Also it used by remote apps to display caller information and message display. When the message log is in Kodi core I might consider this an option though so I'll leave this one open.

dmarcelino commented 8 years ago

I have to admit the toast notifications during video playback also bug me, specially because they are shown in the center of the screen. I would love to either hide them or move them to a more discrete place, one of the corners?

BigNoid commented 8 years ago

Now that the eventlog viewer is in I'll probably will add an option to hide the notifications during video playback. Moving it to the right side of the screen sounds like a good idea too.