Closed MikeSiLVO closed 1 year ago
@mikesilvo164 My time is very limited atm, so no real time to review this properly for a while. Will get back on this, but probably not for another week or 3.
@BigNoid No worries, my time is also more limited so no rush at all since I am still finding little issues here and there.
I am using the line notes to mark any bugs/typos I see when I do a code review after I fix any previously noticed ones... there always seems to be a couple of little things I missed ;)
Thanks.
@BigNoid PR updated with, I believe, the last remaining fixes.
I will keep this branch updated with any future commits and there is still absolutely no rush on this :wink:
Have a great holiday and a happy new year :smiley:
Hi, @BigNoid
I wanted to get your opinion on a couple of things and since I am taking a break from the Kodi forums for a little bit, I thought creating a PR and asking here would be best (if not I sincerely apologize).
First, is the addition of the Icons layout for the main menu... I wanted to check with you about your thoughts on its current implementation An example is commenting this out, as its use case is not readily apparent to me so I do not know what it might break?. Second, would you prefer I localize some strings in a section not used like in the 31700 range or would you like to handle that if this is in fact a wanted addition? Example
I understand this is all dependent on your decision to merge but I wanted to ask since my side project is working on this and finding/fixing any bugs I can for this PR and I (think) I am running out of things to do other than start the 21:9 part ;)
I have been replacing the branch every couple of days so it is not the same from its created date of 7 days ago.
I definitely did not post a bug free link in my previous PM :( but this PR should be almost bug free (I hope)
Thanks :)