search

BigNoid / Aeon-Nox

A skin for XBMC/Kodi
Other
253 stars 187 forks source link

Add OSDSubtitleSettings button #755

Closed MikeSiLVO closed 6 years ago

MikeSiLVO commented 6 years ago

@BigNoid I couldn't find a better button for the new subtitles settings dialog so I changed the onclick to open that instead. The new dialog has a Download subtitles button so I added a condition to the fade animation that already hides DialogSettings when SliderDialog is visible.

BigNoid commented 6 years ago

Makes sense to do it this way. Its more clicks now to download subtitles, but having 2 subtitle related buttons is overkill. Thx!

MikeSiLVO commented 6 years ago

I did try something else but am not sure if I will keep it... Screenshot Ignore silly screenshot kids are watching the movie Babe ATM 😏

I added that here but originally I wanted to use sortletter_back.png cause of the nice arrow shape at the bottom but I still have not learned how to make my own images and the stretched version looked pretty bad...

BigNoid commented 6 years ago

It breaks the look imo. I would rather have it via longpress on the subtitle button, but unfortunately that’s not available for skin code afaik.

MikeSiLVO commented 6 years ago

I agree, will probably remove that. Maybe the download subtitles button could be moved to the top of OSDSubtitlesSettings so it is less travel.

Longpress is a cool idea like how oninfo was added. Something like an onhold or onlongpress would be fun to play around with...