search

BigSamu / OpenSearch_Changelog_Workflow

A reusable workflow for automating changelog and release notes generation processes for OpenSearch repos
Apache License 2.0
0 stars 4 forks source link

Add "Skip Changelog" label to PR #1

Closed JohnathonBowers closed 9 months ago

JohnathonBowers commented 9 months ago

If a contributor enters a - skip line in their PR description, the workflow should add a "Skip Changelog" label to the PR.

JohnathonBowers commented 9 months ago

I've manually tested the functionality of these changes, and everything works as expected.

I updated the PR description in our feature branch to just have a "- skip" entry. Below are the logs from the workflow:

Screenshot 2023-12-05 at 6 18 41 PM

Next, I updated the PR description by removing the "- skip" entry and adding "- feat: Adds a new feature". Below are the logs from the workflow:

Screenshot 2023-12-05 at 6 19 00 PM

Finally, here is a screenshot of the commits generated by each workflow, showing that the "skip-changelog" label was added and removed as expected:

Screenshot 2023-12-05 at 6 16 19 PM

The last major task remaining is to add unit tests for this new function.

BigSamu commented 9 months ago

That is perfect @JohnathonBowers! Let me take responsibility for testing those features. Could you open an issue for that?

JohnathonBowers commented 9 months ago

Thanks, @BigSamu ! I've added Issue #12 for the unit tests for this feature.

BigSamu commented 9 months ago

@JohnathonBowers, tests for this feature have already been created and are ready for review in PR #16.

I am closing this issue because the updates done here were made directly in the 'main' branch (no PR associated)