search

BigSamu / OpenSearch_Changelog_Workflow

A reusable workflow for automating changelog and release notes generation processes for OpenSearch repos
Apache License 2.0
0 stars 4 forks source link

Change logic for making Chnagelog Description Optional if App not installed #48

Closed BigSamu closed 3 months ago

BigSamu commented 6 months ago

Currently, the Changelog Workflow enforce the need for a Changelog section in the PR Description. Because an option for adding changesets manually must be available, this enforcement should not be added.

For that purpose, a new logic should be implemented in the workflow that follows this logic:

if (isAppInstalled) {
  // check and parse changelog description
  // Send request to bot to add changesets 
} else {
  // Post message to show two options for adding changesets: manual or automatic
      // If manual option selected -> add changesets files and check formatting
      // If automatic option selected -> install bot and update PR Chnagelog description 
}
ashwin-pc commented 3 months ago

Isnt this done with the manual changeset work?

BigSamu commented 3 months ago

Yes, it is done. It is addressed in release [v1.0.0-alpha (https://github.com/BigSamu/OpenSearch_Changelog_Workflow/releases/tag/1.0.0-alpha1). Closing issue.