BigThunderSR / homeassistant-addons-onstar2mqtt

OnStarJS wrapper for MQTT as a Home Assistant Add-on
Apache License 2.0
21 stars 2 forks source link

MQTT_LIST_ALL_SENSORS_TOGETHER - Not working #561

Closed jrprinty closed 2 months ago

jrprinty commented 2 months ago

I have been using the Vehicle 1 variant for the past year without issues and really appreciate all the improvements that have been made in this short time.

My wife just bought a GMC Terrain and I'm setting it up with the Vehicle 2 variant now and am unable to combine the sensors even though it is set to true.

I set the Add-on up with this turned on and when I noticed it didn't work correctly, I turned it off and on again. I also restarted Home Assistant and removed the relavent MQTT information from the server. I have also tried it with and without the MQTT_ONSTAR_POLLING_STATUS_TOPIC of: homeassistant/onstar2mqtt/vehicle2/polling

I'd be happy to getting you any information you need but am unsure if logs would help or not. I'm attaching what I think would be relavent from the config yaml:

MQTT_PREFIX: homeassistant MQTT_ONSTAR_POLLING_STATUS_TOPIC: "" MQTT_LIST_ALL_SENSORS_TOGETHER: true

Screenshot 2024-06-22 at 08 43 08@2x

This isn't a big deal but it would be nice to have them all under the one entity in Home Assistant.

OnStar2MQTT Home Assistant Add-on (BigThunderSR) for Vehicle 2 Current version: 1.18.5

Home Assistant: Core: 2024.6.4 Supervisor: 2024.06.0 Operating System: 12.4 Frontend: 20240610.1

BigThunderSR commented 2 months ago

The Vehicle 2 code is pretty much a duplicate of the Vehicle 1 code, so this is interesting. I'll have to take a look and see what the issue may be.

BigThunderSR commented 2 months ago

Just found the problem and I'll get a fix out this weekend. Thanks for highlighting the issue.

BigThunderSR commented 2 months ago

The update I just pushed out should correct this issue. Please confirm.

jrprinty commented 2 months ago

Thank you for the quick turn around on getting this fixed.

I did have to delete the MQTT topics manually to update Home Assistant.

Thank you, AGAIN!

BigThunderSR commented 2 months ago

No worries. It was human error on my part that caused the issue in the first place. 😄