search

BigUglySpider / EmuLibs

Selection of libraries designed to be used with Emu projects. This was originally a Math library only, but has since been changed to hold all Emu libraries to enable consistency in changes to dependencies (such as EmuCore modifications).
https://biguglyspider.github.io/math
0 stars 0 forks source link

MatrixRotation[Axis][Units]Constexpr functions do not take new constexpr functor params into account #14

Closed BigUglySpider closed 3 years ago

BigUglySpider commented 3 years ago

They still work due to default arguments, however they could be updated to better reflect the new DoMod_ template argument, so that users can avoid unneeded mods.

By default a mod will be performed even for values in the range of 0-359 degrees (and the radian equivalents for radian unit functions), and there is no way to prevent this.

Impacts may be minimal due to rotation matrices not being made extraordinarily often, but it makes sense to make this consistent with the other functions that make use of cos/sin/tan constexpr functors.

BigUglySpider commented 3 years ago

As of commit a748429d19b6597024f732a71978eb574abb9f2a, the DoMod_ argument has been integrated into rotation matrix generation functions.

The functions have additionally been updated to take a boolean argument indicating if radians or degrees are being passed, which defaults to radians, to be more in line with other functions which take angles.