Closed BigUglySpider closed 1 year ago
Pinning due to high priority.
As of commit fc5f7dca381b4bdefbc7fc029594221df7506a7c this issue has now been addressed.
Notable info:
load
/store
for unaligned loads/stores, as suggested, but instead of the syntax loada
/storea
for aligned loads/stores we use aligned_load
/aligned_store
.
aligned_load
/aligned_store
operations to provide the exact same functionality as before, but now opt-in for aligned expectationload
/store
they were calling now being unaligned-by-default
It is fairly unintuitive to expect the user to opt into all instances in which they believe their data will be unaligned, and instead they should opt in when they know it will be aligned.
As such, this suggests the following:
load
,loadu
,store
,storeu
for aligned/unaligned loads/stores)load
,loada
,store
,storea
for unaligned/aligned loads/storesThis has already proven to be an issue with some areas which are unexpectedly segfaulting as a result of the alignment expectation by default.