BigWigsMods / BigWigs

Modular, lightweight, non-intrusive approach to boss encounter warnings.
253 stars 189 forks source link

Autologging breaks logs in M+ keys #1330

Open ljosberinn opened 1 year ago

ljosberinn commented 1 year ago

Describe the problem

BigWigs autologging breaks logs in M+ keys as it stops logging on ENCOUNTER_END which gets fired multiple times in a dungeon. Consider adopting the same approach MRT uses:

What steps will reproduce the problem?

  1. Enable autologging in settings
  2. Start a key
  3. Upload the log after the key or use live logging
  4. Observe how either:
    • the log records up until the end of the first boss of the dungeon and nothing after
    • the log records up until the end of the first boss of the dungeon and only bosses onwards
    • the log records exclusively bosses

What version of BigWigs are you using? (Stating 'latest' is not useful)

Latest, but this is a long outstanding issue for at least 6 months.

Do you have an error log of what happened?

No error thrown.

Any additional information? (example: WoW language if not English)

Suggestion: do not stop logging if CHALLENGE_MODE_START was observed, until CHALLENGE_MODE_END is seen OR another CHALLENGE_MODE_START (due to abandoning a key)

ljosberinn commented 10 months ago

we're getting a report of this being an issue every other day, any plans on this? it's nearing its first birthday :)