BigWigsMods / Transcriptor

Logging utility for boss encounters.
9 stars 10 forks source link

Mass Errors in Classic #22

Closed MysticalOS closed 5 years ago

MysticalOS commented 5 years ago

What steps will reproduce the problem?

  1. Turn on logging
  2. Ensure stuff is cast
  3. Stop logging, error

What version of Transcriptor are you using?

Latest classic version

Do you have an error log of what happened?

multiple locations, pretty much every attempt to compare events using spellId (the TIMERS table building code)

Please provide any additional information below. (example: localization of your client if not enUS or enGB)

Locally I tested just changing the TIMERS table to build using spellName instead of spellId, as well as fixed SPELL_DAMAGE aggregation code to also use spellName instead of spellId and I think that cleaned up all errors. but I did this about a week ago when beta was back up, I can't access the bugsacks now to recall all places it needed to address. Just search for anything still relying on spellId not being screwed up :D