BiggerSeries / BiggerReactors

GNU Lesser General Public License v2.1
12 stars 18 forks source link

Reactor voiding fuel when joining world [0.6.0-beta.6] #71

Closed dredgemage closed 1 year ago

dredgemage commented 1 year ago

I'm running an All The Mods 8 server and a couple of my players have reported that when logging out and logging back in the reactor's fuel will be gone. I had them test without any automatic fuel inset or waste extract and it still occurred. Screenshot below. I am unable to replicate the issue in a single player world.

2023-01-24_21 42 01

dredgemage commented 1 year ago

Update: Reassembling the reactor 1 block to the east (back and left in the picture) so that it is no longer adjacent to the chunk boundary resolves this issue.

RogueLogix commented 1 year ago

I'm unable to reproduce this as described in singleplayer or on a server

Talkarcabbage commented 1 year ago

So far I don't think it is related to being on a chunk border.

Server host is Ubuntu server 18.04.5LTS Client on Windows 11

When I had it happen to mine, it was inside a compact machine and not against any of the walls, so it shouldn't have been on a chunk border.

I had one round of unsuccessfully recreating it when building a reactor in the same compact machine spot. In that attempt it worked perfectly.

In a second attempt rebuilding it in the same spot, I managed to encounter an issue that is possibly related that will be explained below. Leaving and rejoining the reactor room without having mined any of the blocks then recreated the issue.

The things done differently in the second rebuild that I can recall (number 1 I know I did the first time it happened to me) were

  1. Frequently leaving and re-entering the compact machine during construction, thereby unloading the partially built but uninitialized device.
  2. Misclicked with a Pipez Pipe Wrench on the input port, which apparently switches it between input and export modes? Though the first time I did it, it didn't seem to do anything.
  3. Broke a block and replaced it with a controller as the last step to finish the reactor. The room had been unloaded and reloaded a few times in the interim.
  4. One more person was on the server, so there is more lag and a fair bit of periodic tick skips currently.
  5. Possibly different order of block placements, but didn't pay attention to the exact details. Placed the input and outputs on a separate side than the first time.

The reactor was started without issue and I used a pipez item pipe to pipe in one uranium ingot, accidentally right clicking at that moment per point 2. I adjusted the control rods, then tried to use the terminal, which caused it to go black and give me an error in chat after some lag. An unknown multiblock error has occurred, report to mod author per https://puu.sh/JzyGf/0a94bdc927.png Leaving and rejoining the room at this point resets the reactor's fuel/power/on-off status per the existing issue every time, but doesn't seem to affect the control rods.

I was having some network lag at the time (hotspots are great internet) so I wasn't really able to tell if the server was having a frame skip at that time. I did not see any errors in the server console at the time.

I didn't encounter that error message the first time this happened, but I don't know if it could have been something in the background that happened to it that broke it before I noticed the first time. Likewise I can't guarantee that error is directly related, but it seemed good to include.

Another picture of the general setup of the currently broken instance. https://puu.sh/JzyPG/e1e97d263f.jpg

RogueLogix commented 1 year ago

Finally was able to reproduce a potentially related bug, its a race condition, and wont reproduce on my desktop but will my server

Lord-Volkner commented 1 year ago

I'm having this issue in my single-player world. I lose all fuel loaded into the reactor and all RF stored in the reactor. Specifically, when I leave the game and return.

I said I would edit the video, but it ended up being only 3 minutes long. It's an uncut, unaltered video of me showing the fuel (and RF stored in the reactor) then logging out and back in:

https://odysee.com/@Volkner:9/ATM8_lost_reactor_fuel-RF:c

RogueLogix commented 1 year ago

Bug that was reproduced could easily cause this, so removing that label, but as I can't easily reproduce it, I will leave this issue open for a while after in case its not fixed.

Lord-Volkner commented 1 year ago

Now running:

biggerreactors-1.19.2-0.6.0-beta.6.1

I'm not sure how to tell, but best I can figure this is the most recent.

Unfortunately the problem still exists for me.

PiecewiseLantern commented 1 year ago

I'm also seeing Lord-Volkner's exact issue while using BR in ATM8, which is version 1.19.2-0.6.0-beta.6.1.

If there is any extra information that I can provide (world save etc.) I'm happy to share.

estafeit commented 1 year ago

Same problem here, with ATM 8 and beta 6.1, on a freshly built reactor. Reactor is totally inside, and not touching, chunk boundaires. If I can be of any help.

RogueLogix commented 1 year ago

If you can make it happen reliably, that's what I really need. It's basically impossible for me to try and fix this by poking in the dark.

If reloading your world is all it takes and it does it every time, then I'll need your world so I can attach a debugger to it.

estafeit commented 1 year ago

I guess it is, I mean, I only restarted the word three times for now. Do you need the whole instance or only save ? Also, can I upload that kind of file here ? (the savegame only is 500Mb, )

RogueLogix commented 1 year ago

Just the savegame is fine, if you want you can send it or a link to it, to me on discord (server link on CurseForge) or here, whichever you prefer.

estafeit commented 1 year ago

Here it is, don't mind the name ^^'

https://1drv.ms/u/s!Aq-PKGxMbagF7Xgr2E0Rtzlyepeq?e=IN51Ar

I don't know if you need details but it's a GDLauncher instance of latest ATM 8 (1.0.15, updated yesterday)

Lord-Volkner commented 1 year ago

If you can make it happen reliably, that's what I really need. It's basically impossible for me to try and fix this by poking in the dark.

If reloading your world is all it takes and it does it every time, then I'll need your world so I can attach a debugger to it.

Let me know if you need mine also. My save game folder is 4.31 GB. Not sure what is "just the savegame" other than the whole save folder, but I'm sure I could delete a bunch of the region data and such to make it a more manageable size.

RogueLogix commented 1 year ago

reproduced in @estafeit's world

RogueLogix commented 1 year ago

reproduced in dev environment. reproduction requires a multiblock (this effects turbines too) to be reloaded before first completion. this gets the NBT into a weird state where it skips writing to all blocks.

immediate solution is to completely rebuild the effected multiblock without reloading it until the next phos version that will have it fixed

Lord-Volkner commented 1 year ago

immediate solution is to completely rebuild the effected multiblock without reloading it ...

What does that mean?

RogueLogix commented 1 year ago

remove every block of the reactor and rebuild it without exiting the area.

if singleplayer, just grab this phos version once its done building https://github.com/BiggerSeries/Phosphophyllite/releases/tag/0.6.0-beta.7.1

estafeit commented 1 year ago

Following your procedure definitely solved it for me. The end of power shortages ! Thank you.

RogueLogix commented 1 year ago

As this issue appears to be actually be fixed now, I'm going to close this issue. If it continues, comment and I'll reopen it.