search

BiggerSeries / Phosphophyllite

GNU Lesser General Public License v2.1
4 stars 5 forks source link

Fix crash when trying to move the reactor with a bag of yurting #2

Closed alesharik closed 3 years ago

alesharik commented 3 years ago

This PR fixes crash when trying to move the reactor with a bag of yurting. Also, it adds grade wrapper and removes broken repos from the build file to make contributing easier

RogueLogix commented 3 years ago

this exact modification is currently done in 2e8d7aba53d6ecb56982ae29e7974a414e66b5b3 for 0.5

that said, i highly recommend against using a bag of yurting with reactors, as it is a really easy way to maybe break them, and probably break your player file.

the gradle project will be fixed for independent compiling of phosphophyllite before the first 0.5 alpha on the 0.5-dev, currently it is setup for cloning of https://github.com/BiggerSeries/BiggerSeries

alesharik commented 3 years ago

Is there any chance that 2e8d7ab will be backported to 0.4? Or I should use patched mod until 0.5 will be out ?

RogueLogix commented 3 years ago

its probably not going to be backported, so if you want to use a bag of yurting, you will need to ues a patched version. that said i would recommend against it regardless as there is a non-negligible amount of NBT for a reactor which is saved with every block, and you could easily break your player file by trying to yurt one around.