search

BiglySoftware / BiglyBT-plugin-rssfeed

An RSS feed parser that allows unattended, automated download of torrents by means of advanced feed filter configurability.
GNU General Public License v2.0
4 stars 4 forks source link

Strange rssfeed option for "Movies" !RSSFeed.Options.Filter.filtType.Movie! #2

Open n1diot opened 6 years ago

n1diot commented 6 years ago

For while while now I have had 4 options for "Type"

  1. TVShow
  2. !RSSFeed.Options.Filter.filtType.Movie!
  3. Other
  4. None

But the 2. !RSSFeed.Options.Filter.filtType.Movie! used to be called "Movie" I think, and gives the option to "Disable After Success"

First, the name is strange, second it doesn't disable after successful download completion.

I have tried;

I am at a loss myself, but I am not a programmer - and I did notice this with Vuze before moving to BiglyBT - which is GREAT! btw :)

If anyone could assist me, or tell me this is normal operation now (as it used to work a long time ago and turn off the filter after successful download.

Regards;

image

parg commented 6 years ago

I just released 1.6.7 which fixes that text issue and another bug regarding seting the mode (to pass/fail). For me this fixed a few things but the guy that reported it says it is still failing for him :( Not sure about the 'disable after success' thing - it isn't my plugin but I have been making minor fixes to it for a while

n1diot commented 6 years ago

Hey Parg, thanks for the reply - and I do understand inheriting someone else's work, I am in I.T myself as a managed services provider, so I understand. I will try and find the 1.6.7 and install that.

You can only do what you can, I tend to check everyday for Movies, so I usually catch it before it downloads twice :)

If you do come up with something for the "Disable After Success" to work - you'd be a real gem!

Regards;

n1diot commented 6 years ago

OK - found the 1.6.7 plugin and installed. *Thank you for your efforts on this plugin!

I can confirm that;

  1. The !RSSFeed.Options.Filter.filtType.Movie! now shows as MOVIE - I had to change quite a few of the movies from "TVShow" to "Movie" - or "Other" (which I had set myself to "Other" and changed to "Movie")

  2. I will not be able to confirm if the disable after success will work until the next Movie comes out and downloads. But I am holding hope, as I mentioned in point 1. the !RSSFeed.Options.Filter.filtType.Movie! defaulted to "TVShow" and changing to "Movie" feels like something has potentially changed *here's hoping :)

  3. I can also confirm that "Fail" - even being at the very top of the list does show Green, like in the following post : https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/issues/1

image

  1. I hope I am incorrect, and my "TVShow" smart history is working!
    • Seems to be keeping the history! Back until OCT 2017 - sorry about my terrible scrub out, but it's a private tracker :)

image

parg commented 6 years ago

Hi - I've been away for the last few days - please keep me posted on any issues! Thanks

ferdnyc commented 3 years ago

Hah! Turns out, "Disable after success" doesn't work because it's an option only for "Movie" type filters, but the code only applies it if the filter type is "Other". D'oh.

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/Scheduler.java#L585-L587

ferdnyc commented 3 years ago

This is actually kind of a mess. Near as I can tell, the "Disable after use" option is supposed to be an option for the "Other" type, not "Movie". That's certainly what the comments imply. But there are a bunch of places in the HistoryBean and FilterTableItem code where the type value is interpreted as an integer, and filtDisable is associated with type index 1.

Problem is, inserting "Movie" as a type pushed "Other" to be the third option in that combo box, which means its actual index is 2, not 1.

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/FilterBean.java#L36-L39

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/View.java#L674-L684

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/View.java#L730-L736

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/FilterTableItem.java#L92-L101

ferdnyc commented 3 years ago

The Movie type is also (based on lines 540-580 of Scheduler.java) supposed to support the same Smart History feature as TV Show, but there's no check box shown to enable it for that type.

ferdnyc commented 3 years ago

Also, just a random observation: This... is bananas. B-A-N-A-N-A-S.

https://github.com/BiglySoftware/BiglyBT-plugin-rssfeed/blob/19a2e11bcf922eb7a786b1bae1e5e6a4f4301216/org/kmallan/azureus/rssfeed/View.java#L1468-L1508

parg commented 3 years ago

I hate this plugin... Maybe you could send over a nice pull-request with everything working :)

Switches with case statements that drop through without a break - never liked the look of them and certainly wouldn't use it without a big comment saying that it was the intended behaviour...