BiglySoftware / BiglyBT-plugin-rssfeed

An RSS feed parser that allows unattended, automated download of torrents by means of advanced feed filter configurability.
GNU General Public License v2.0
4 stars 4 forks source link

Don't grow options table container to contents #4

Closed ferdnyc closed 3 years ago

ferdnyc commented 3 years ago

I've been having a problem for a while with the Options view, where the toolbars for the tables on the left side wouldn't show up because they were scrolled out of view.

Turns out, the ScrolledComposite container which holds all of those elements was being expanded to have its minSize equal the size of its contents, which is maybe not the best thing when dealing with tables that can have very wide columns (either intentionally or purely by accident). Once the table columns were widened, the container would expand, but it wouldn't later shrink down again even if the table itself were made narrower.

I'm not convinced that container should be a ScrolledComposite at all, since having it scroll is never really desirable. (The tables' contents will scroll, which is correct and proper.) Nevertheless, to keep things simple I didn't change that, just set it up to only scroll vertically (same as the other column in that tab), and removed the line that computed an excessive minSize for it. Works For Me™ on Linux.